Fix action pins to resolve tags exactly as specified #10567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving action versions (e.g., "v4"), the system now returns exactly the requested version in the version comment, not a more precise version like "v4.6.2". This fixes the issue where the system was trying to be smart by replacing user-specified tags with more precise versions. Changes: - Removed isMorePreciseVersion logic from GetActionPinWithData - Added test TestGetActionPinWithData_ExactVersionResolution to verify behavior - Updated test expectations to match new exact-version behavior Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated test expectations in TestActionPinResolutionWithMismatchedVersions to match actual hardcoded pin versions: - ai-inference: v2 (not v2.0.4) - github-script: v7 (exact match, not v8.0.0 fallback) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test for resolving GitHub action tag references
Fix action pins to resolve tags exactly as specified
Jan 18, 2026
Contributor
|
@copilot recompile |
Contributor
Author
Recompile completed successfully. All 129 workflows are up to date - no changes were generated since the action pins logic changes don't affect the existing compiled workflows. |
This was referenced Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving action versions dynamically, the system was replacing user-specified tags (e.g., "v4") with more precise versions from the cache (e.g., "v4.6.2") if they pointed to the same SHA. This caused version comments to flip unexpectedly between compilations.
Changes
GetActionPinWithData()that checked cache for "more precise" versions and substituted themTestGetActionPinWithData_ExactVersionResolutionverifying exact tag resolution with dynamic resolverBehavior
Fallback to hardcoded pins (when no resolver available) remains unchanged - exact match preferred, semver-compatible fallback if needed.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.