Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Jan 21, 2026

Summary

  • Enhanced network configuration validation for MCP servers with containers
  • Added support for top-level network configuration as an alternative to per-server network config
  • Improved error messaging for network security in strict mode

Details

The changes modify the validateStrictMCPNetwork function to:

  • Accept a top-level network permissions parameter
  • Allow network configuration at either the server or workflow level
  • Provide more precise validation for servers with containers
  • Maintain backward compatibility with existing network configuration approaches

Test Coverage

Multiple test cases have been added to verify:

  • Server-specific network configurations
  • Top-level network configurations
  • Mixed configuration scenarios
  • Error handling for missing network settings

@pelikhan
Copy link
Contributor

Proposed action is to remove completely network specification from mcps currently until we bring it back through the spec and im plement this in the gateway.

@dsyme
Copy link
Contributor Author

dsyme commented Jan 21, 2026

The fix in the PR looks like it is using the workflow-level network permissions for validation if there is no MCP-specific network permission present. Which seems correct.

But yeah a separate cleanup to remove the MCP-specific network permissions could/should be done.

@dsyme dsyme merged commit 0be4e52 into main Jan 21, 2026
50 checks passed
@dsyme dsyme deleted the gwq branch January 21, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants