Skip to content

Conversation

@Krzysztof-Cieslak
Copy link
Member

Automatically created PR to add workflow: githubnext/agentics/issue-triage

# not appropriate for triage workflows, so here we allow one run
# per issue at a time.
concurrency:
group: "triage-${{ github.event.issue.number }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like this kind of "pick the right concurrency" should just work. Our compiler should do the right thing and emit a concurrent id with workflow / issue number

Copy link
Member Author

@Krzysztof-Cieslak Krzysztof-Cieslak Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this

concurrency:
   group: "triage-${{ github.event.issue.number }}"

is taken directly from actions synteax.

It feels we should introduce some "higher level" syntax for this thing like concurrency: per-issue or concurrency: single and let compiler generate action-specific syntax

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.... concurrency key has no logging output as far as I know . Very hard to trace.

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 3ca46c9 into main Aug 13, 2025
6 checks passed
@Krzysztof-Cieslak Krzysztof-Cieslak deleted the add-workflow-issue-triage-7829 branch August 13, 2025 11:44
pelikhan added a commit that referenced this pull request Aug 25, 2025
* Replace check-team-member shared action with inlined JavaScript script (#22)

* Initial plan

* Replace check-team-member template with inlined JavaScript script

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Fix code formatting (remove trailing whitespace)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Add check_team_member.cjs to tsconfig.json and create comprehensive tests

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>

* Refactor compute_text_action.yaml as embedded JavaScript with sanitization (#25)

* Simplify add-reaction feature by removing fallback and try/catch logic (#24)

* Initial plan

* Reimplement add-reaction feature as inlined JavaScript

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Remove "remove" functionality from add-reaction feature, simplify to only support adding reactions

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Remove fallback and try/catch clauses from add-reaction feature

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>

* Remove compute-text action dependency and template files from workflow system (#29)

* Fix linter issues: Remove unused reactionActionTemplate variable (#30)

* Add output text to test-claude and inline JavaScript instead of shared actions (#32)

* Remove obsolete reaction_action.yaml template file (#34)

* Remove unnecessary content permissions and checkout steps from task and add_reaction jobs (#35)

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants