-
Notifications
You must be signed in to change notification settings - Fork 34
Migrate actions/upload-artifact from v4 to v5 #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Updated action_pins.json to use v5 (330a01c490aca151604b8cf639adc76d48f6c5d4) - Updated all workflow files to use v5 instead of v4 - Updated test files to expect new v5 SHA - Rebuilt binary and recompiled all workflows - Verified no warnings about upload-artifact resolution Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the actions/upload-artifact action from v4 to v5 across the entire codebase. The update involves changing both the pinned SHA commit reference and the version tag in workflow files, test files, and documentation.
Key changes:
- Updated
actions/upload-artifactfrom v4 (SHA:ea165f8d65b6e75b540449e92b4886f43607fa02) to v5 (SHA:330a01c490aca151604b8cf639adc76d48f6c5d4) - Updated action pins configuration file with new version metadata
- Updated test assertions to expect the new SHA reference
- Added schedule trigger to one workflow that previously had none
Reviewed Changes
Copilot reviewed 80 out of 80 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/data/action_pins.json |
Updated upload-artifact version from v4 to v5 with new SHA |
pkg/workflow/*_test.go |
Updated test expectations to match new v5 SHA reference |
.github/workflows/*.lock.yml |
Updated compiled workflow files with new upload-artifact v5 SHA |
.github/workflows/*.md |
Updated source workflow files from pinned v4 SHA to v5 tag |
docs/src/content/docs/status.mdx |
Added missing schedule information for repo-tree-map workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Agentic Changeset Generator triggered by this pull request. |
Compiler was emitting warnings about being unable to resolve
actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874dynamically, falling back to hardcoded v4 pin instead of the requested v4.4.0.Changes
actions/upload-artifactto v5 (SHA:330a01c490aca151604b8cf639adc76d48f6c5d4)@v4/@50769540e7f4bd5e21e526ee35c689e35e0d6874to@v5Before:
After:
Compiled workflows now reference
330a01c490aca151604b8cf639adc76d48f6c5d4consistently without resolution warnings.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v5.0.0curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.