-
Notifications
You must be signed in to change notification settings - Fork 28
Update github.com/spf13/cobra from v1.9.1 to v1.10.1 #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the spf13/cobra dependency from v1.9.1 to v1.10.1 and adds a new agentic workflow "Typist - Go Type Analysis" to the documentation status page. The dependency update affects both go.mod and go.sum files with corresponding hash changes.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates spf13/cobra dependency from v1.9.1 to v1.10.1 |
| go.sum | Updates checksums for spf13/cobra v1.10.1 and spf13/pflag v1.0.9 |
| docs/src/content/docs/status.mdx | Adds new "Typist - Go Type Analysis" workflow entry to status table |
| docs/src/content/docs/reference/frontmatter-full.md | Contains an unintended change to the deprecated field example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # to 15 minutes for agentic workflows. | ||
| # (optional) | ||
| timeout-minutes: 10 | ||
| timeout_minutes: 10 |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field name in the example should be 'timeout-minutes' not 'timeout_minutes'. According to the documentation on line 673, this field is deprecated and should use 'timeout-minutes' instead. However, since this is documenting the deprecated field, it should remain as 'timeout_minutes' to show the old syntax. The change appears to be unintentional - reverting from 'timeout-minutes' to 'timeout_minutes'.
🔍 Nitpick Review CompleteI've reviewed PR #3445 (Cobra dependency update from v1.9.1 to v1.10.1) and found 1 minor documentation issue. What I Reviewed
The NitpickDocumentation inconsistency: In Positive Highlights✅ Clean dependency management: The Cobra update is well-structured with proper transitive dependency tracking This is a solid dependency update PR! The only issue is a minor typo in documentation that should be corrected to avoid confusion.
|
| # to 15 minutes for agentic workflows. | ||
| # (optional) | ||
| timeout-minutes: 10 | ||
| timeout_minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Documentation inconsistency - the example shows timeout_minutes: 10 but the field name should be timeout-minutes (with a hyphen) to match GitHub Actions YAML conventions and the description above it.
Why it matters: This documentation example could confuse users since GitHub Actions fields use hyphens, not underscores. The comment above correctly states "Use 'timeout-minutes' instead" but the example contradicts this.
Suggested fix: Change to timeout-minutes: 10
AI generated by PR Nitpick Reviewer 🔍 for #3445
Minor version update for the Cobra CLI framework dependency, bringing in pflags v1.0.9 and bug fixes.
Changes
github.com/spf13/cobrafrom v1.9.1 to v1.10.1github.com/spf13/pflagupgraded to v1.0.10What's in v1.10.1
All CLI commands (compile, mcp, logs, audit, status) tested and working. No deprecation warnings or breaking changes detected.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.