Update github.com/spf13/cobra from v1.9.1 to v1.10.1 #3445
+6
−5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -673,7 +673,7 @@ timeout-minutes: 1 | |
| # Deprecated: Use 'timeout-minutes' instead. Workflow timeout in minutes. Defaults | ||
| # to 15 minutes for agentic workflows. | ||
| # (optional) | ||
| timeout_minutes: 10 | ||
|
Contributor
There was a problem hiding this comment. Nitpick: Documentation inconsistency - the example shows Why it matters: This documentation example could confuse users since GitHub Actions fields use hyphens, not underscores. The comment above correctly states "Use 'timeout-minutes' instead" but the example contradicts this. Suggested fix: Change to
|
||
|
|
||
| # Concurrency control to limit concurrent workflow runs (GitHub Actions standard | ||
| # field). Agentic workflows use enhanced concurrency management. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field name in the example should be 'timeout-minutes' not 'timeout_minutes'. According to the documentation on line 673, this field is deprecated and should use 'timeout-minutes' instead. However, since this is documenting the deprecated field, it should remain as 'timeout_minutes' to show the old syntax. The change appears to be unintentional - reverting from 'timeout-minutes' to 'timeout_minutes'.