-
Notifications
You must be signed in to change notification settings - Fork 32
Fix CLI consistency: align mcp inspect examples between standalone and subcommand #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Update standalone version (line 274): Replace "repomind --server repo-mind" with "daily-news --server tavily" - Add missing example to subcommand version (line 549): "gh aw mcp inspect daily-news --server tavily" - Both command definitions now have consistent examples - Used "daily-news" workflow and its "tavily" MCP server per @pelikhan's comment Resolves the inconsistency where the subcommand version was missing an example that appeared in the standalone version. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CLI consistency by aligning the mcp inspect command examples between its standalone version and subcommand version. The standalone version previously showed 7 examples while the subcommand version only showed 6, missing the --server filter example. Additionally, both versions are updated to use a real workflow example (daily-news --server tavily) instead of a hypothetical one (repomind --server repo-mind).
Key changes:
- Updated example on line 274 to reference the actual
daily-newsworkflow withtavilyMCP server - Added the missing
--serverfilter example on line 549 to the subcommand version
Reviewed Changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/cli/mcp_inspect.go | Updated CLI example text and added missing example to ensure consistency between standalone command and subcommand versions |
| .github/workflows/*.lock.yml | Multiple compiled workflow files with added has_patch output handling and detection job conditions (appears unrelated to the PR's stated purpose) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GH_AW_ASSETS_MAX_SIZE_KB: 10240 | ||
| GH_AW_SAFE_OUTPUTS: /tmp/gh-aw/safeoutputs/outputs.jsonl | ||
| outputs: | ||
| has_patch: ${{ steps.collect_output.outputs.has_patch }} |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow lock file changes (adding has_patch output and modifying detection job conditions) appear unrelated to the PR's stated purpose of fixing CLI consistency for mcp inspect examples. These changes affect 72 workflow files and seem to be from a separate feature. Consider splitting these changes into a separate PR focused on patch detection functionality, or update the PR description to explain why these workflow changes are included.
The
mcp inspectcommand had two separate definitions with inconsistent examples. The standalone version showed 7 examples while the subcommand version only showed 6, missing the--serverfilter example.Changes
repomind --server repo-mindto actualdaily-news --server tavilygh aw mcp inspect daily-news --server tavily # Inspect only the tavily serverBoth command definitions now show identical examples. The updated example references the real
daily-news.mdworkflow which imports thetavilyMCP server viashared/mcp/tavily.md.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.