Fix JavaScript test assertions for loadAgentOutput error handling

[Copilot]

Fix All Tests, Format and Lint ✅

All objectives completed successfully!

✅ Test Results

• Go Unit Tests: All passing
• JavaScript Tests: 54 files, 997 tests - all passing
• Fuzz Tests: All passing (FuzzParseFrontmatter, FuzzExpressionParser)
• Code Formatting: All files properly formatted
• Code Linting: All validations passed

🔧 Changes Made

Test Fixes:

1. pkg/workflow/js/create_code_scanning_alert.test.cjs - Updated error assertion
2. pkg/workflow/js/create_discussion.test.cjs - Updated error assertion

Build Fix:
3. pkg/workflow/js/package-lock.json - Regenerated to fix npm ci failures

Change: Updated test assertions from core.setFailed() to core.error() to match the refactored error handling in loadAgentOutput(). Regenerated package-lock.json to ensure npm ci works correctly in CI.

📋 Root Cause Analysis

Test Failures:
The loadAgentOutput() utility function was previously refactored to:

• Use core.error() for error logging (instead of core.setFailed())
• Return a result object with a success flag
• Allow calling scripts to handle errors gracefully

The tests were still expecting the old behavior (core.setFailed()), causing false failures.

npm ci Failure:
The package-lock.json file was formatted with an older npm version. When npm install/ci runs with npm 11.6.2 (Node 24), it expects the newer formatting with multi-line arrays. Regenerating the lockfile with the current npm version fixes this.

✅ Validation Summary

✅ GO UNIT TESTS        - All passing
✅ JAVASCRIPT TESTS     - 54 files, 997 tests passing  
✅ FUZZ TESTS          - All passing
✅ CODE FORMATTING     - All properly formatted
✅ CODE LINTING        - All validations passed
✅ NPM CI              - Now works correctly

Status: Ready for review and merge

Original prompt

Fix all tests, go and JavaScript, fuzz. Format and lint.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR fixes two JavaScript test failures by updating error handling expectations to match the refactored loadAgentOutput() utility function. The utility was previously changed to use core.error() instead of core.setFailed() for error reporting, allowing calling scripts to handle errors gracefully through a success flag pattern. The tests were still expecting the old core.setFailed() behavior, causing false failures.

Key Changes

• Updated test assertions in create_discussion.test.cjs to expect core.error() for JSON parsing errors
• Updated test assertions in create_code_scanning_alert.test.cjs to expect core.error() for JSON parsing errors
• Both changes align with the loadAgentOutput() utility's refactored error handling pattern

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/workflow/js/create_discussion.test.cjs	Updated error handling expectation from core.setFailed() to core.error() for invalid JSON test case
pkg/workflow/js/create_code_scanning_alert.test.cjs	Updated error handling expectation from core.setFailed() to core.error() for invalid JSON test case

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pelikhan]

@copilot fix "npm ci" command

See https://github.com/githubnext/gh-aw/actions/runs/19443788686/job/55633550673#step:7:1