Skip to content

Fix JavaScript test assertions for loadAgentOutput error handling #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Fix JavaScript test assertions for loadAgentOutput error handling #4218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7eef1b
Initial plan
Copilot Nov 17, 2025
199fa6a
Fix JavaScript test failures in error handling
Copilot Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/js/create_code_scanning_alert.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ describe("create_code_scanning_alert.cjs", () => {
setAgentOutput("invalid json");
await eval(`(async () => { ${securityReportScript} })()`);

expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringMatching(/Error parsing agent output JSON:/));
expect(mockCore.error).toHaveBeenCalledWith(expect.stringMatching(/Error parsing agent output JSON:/));
});

it("should handle missing items array", async () => {
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/js/create_discussion.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ describe("create_discussion.cjs", () => {

// Check that it logs the content length first, then the error
expect(mockCore.info).toHaveBeenCalledWith("Agent output content length: 12");
expect(mockCore.setFailed).toHaveBeenCalledWith(expect.stringMatching(/Error parsing agent output JSON:.*Unexpected token/));
expect(mockCore.error).toHaveBeenCalledWith(expect.stringMatching(/Error parsing agent output JSON:.*Unexpected token/));
});

it("should handle missing create-discussion items", async () => {
Expand Down
Loading