-
Notifications
You must be signed in to change notification settings - Fork 34
Add mounts configuration field to sandbox.agent #5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot continue work |
…implementation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Completed the mounts implementation! The missing piece was adding the extraction logic for the mounts field in the frontmatter parser. What was added (commit 149d769):
Implementation is now complete:
Verified working: --mount /host/data:/data:ro
--mount /usr/local/bin/custom-tool:/usr/local/bin/custom-tool:roAll tests pass. Ready for documentation and final validation. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 DEVELOPING STORY: Smoke Copilot Playwright reports failed. Our correspondents are investigating the incident... |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
|
💀 Blimey! Changeset Generator failed and walked the plank! No treasure today, matey! ☠️ |
|
🤖 ALERT: Smoke Copilot No Firewall failed. ANOMALY_DETECTED. REPAIR_REQUIRED. |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
@copilot merge main, recompile |
…nfiguration-field
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
Done! Merged main and recompiled all workflows (commit 8808c24). What was done:
Verified:
The mounts feature is fully functional and up-to-date with main. |
|
🤖 ALERT: Smoke Copilot No Firewall failed. ANOMALY_DETECTED. REPAIR_REQUIRED. |
|
📰 DEVELOPING STORY: Smoke Copilot Playwright reports failed. Our correspondents are investigating the incident... |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
💀 Blimey! Changeset Generator failed and walked the plank! No treasure today, matey! ☠️ |
|
make sure mounts are sorted |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done! Custom mounts are now sorted alphabetically (commit 16cb6fb). Changes:
Verified:
|
Add mounts field to sandbox.agent
Summary
Adds a configuration field "mounts" (string[]) to the sandbox.agent field that allows specifying container mounts using Docker syntax (e.g., "/path/to/source:/path/to/dest:ro"). Custom mounts are automatically sorted alphabetically for consistent output.
Implementation
This PR adds complete support for custom container mounts in AWF (Agent Workflow Firewall) configurations:
Schema & Validation
mountsarray field tosandbox.agentin JSON schema with pattern validationvalidateMountsSyntax()function to validate mount format:source:destination:modero(read-only) orrw(read-write)AWF Integration
copilot_engine.goto include custom mountsParsing & Extraction
Mountsfield toAgentSandboxConfigGo structDocumentation
Example Usage
This generates AWF commands with the custom mounts included as
--mountarguments in alphabetical order.Testing
Recent Changes
Sorted mounts alphabetically
Merged from main
Recompiled workflows
Files Changed
pkg/parser/schemas/main_workflow_schema.json- Schema definitionpkg/workflow/sandbox.go- Struct and validationpkg/workflow/copilot_engine.go- AWF integration with alphabetical sortingpkg/workflow/frontmatter_extraction.go- YAML parsingpkg/workflow/sandbox_mounts_test.go- Test suite including sorting testpkg/cli/workflows/test-custom-mounts.md- Integration testdocs/src/content/docs/reference/sandbox.md- Documentation.github/workflows/*.lock.yml- Recompiled workflows after mergeOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.