Use DefaultNodeVersion constant in GenerateNodeJsSetupStep #7384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenerateNodeJsSetupStep()function hardcoded Node.js version '24' instead of using the existingconstants.DefaultNodeVersionconstant, creating duplicate version definitions.Changes
pkg/workflow/nodejs.go: Replace hardcoded'24'withfmt.Sprintf("node-version: '%s'", constants.DefaultNodeVersion)github.com/githubnext/gh-aw/pkg/constantspackageBefore/After
Both
runtime_setup.go(runtime manager) andnodejs.go(Node.js setup function) now reference the same constant for the default Node.js version.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
4d63.com/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)cloud.google.com/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)gitlab.com/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go-simpler.org/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go.googlesource.com/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go.opencensus.io/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go.opentelemetry.io/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go.uber.org/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)go.yaml.in/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)google.golang.org/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)gopkg.in/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)honnef.co/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)k8s.io/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)mvdan.cc/update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git(dns block)/update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.