Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 23, 2025

The GenerateNodeJsSetupStep() function hardcoded Node.js version '24' instead of using the existing constants.DefaultNodeVersion constant, creating duplicate version definitions.

Changes

  • pkg/workflow/nodejs.go: Replace hardcoded '24' with fmt.Sprintf("node-version: '%s'", constants.DefaultNodeVersion)
  • Add import for github.com/githubnext/gh-aw/pkg/constants package
  • Update function comment to reference the constant

Before/After

// Before
func GenerateNodeJsSetupStep() GitHubActionStep {
    return GitHubActionStep{
        // ...
        "          node-version: '24'",
        // ...
    }
}

// After
func GenerateNodeJsSetupStep() GitHubActionStep {
    return GitHubActionStep{
        // ...
        fmt.Sprintf("          node-version: '%s'", constants.DefaultNodeVersion),
        // ...
    }
}

Both runtime_setup.go (runtime manager) and nodejs.go (Node.js setup function) now reference the same constant for the default Node.js version.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 4d63.com
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • cloud.google.com
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • gitlab.com
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go-simpler.org
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go.googlesource.com
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go.opencensus.io
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go.opentelemetry.io
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go.uber.org
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • go.yaml.in
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • google.golang.org
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • gopkg.in
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • honnef.co
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • k8s.io
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)
  • mvdan.cc
    • Triggering command: /update-job-proxy /update-job-proxy GO111MODULE 64/bin/go git -C pload-artifact/git/ref/tags/v5 rev-parse /usr/bin/infocmp -json GO111MODULE ache/go/1.25.0/xHEAD infocmp -1 xterm-color go /usr/bin/git -json GO111MODULE x_amd64/compile git (dns block)
    • Triggering command: /update-job-proxy /update-job-proxy -o br-1e455b2359cd -j DROP /go/pkg/mod/cache/vcs/b42f09cc06--stdin rev-list /home/dependabot/bin/git 5 --quiet 0 git remo�� add e28e00238d94070fb9972fd8:go.mod /bin/git ock /usr/bin/git /home/dependabot-t git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

The runtime manager should install node 24 by default unless specified otherwise (used with actions/setup-node)

Store this version in a constant in constants.go


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

… nodejs.go

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Set default Node version to 24 in constants.go Use DefaultNodeVersion constant in GenerateNodeJsSetupStep Dec 23, 2025
Copilot AI requested a review from pelikhan December 23, 2025 11:54
@pelikhan pelikhan marked this pull request as ready for review December 23, 2025 12:02
@pelikhan pelikhan merged commit 7a9a510 into main Dec 23, 2025
4 checks passed
@pelikhan pelikhan deleted the copilot/set-default-node-version branch December 23, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants