Merge main branch into security fix PR for Alert #83 #7700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/agent-performance-analyzer.lock.yml # .github/workflows/agentics-maintenance.yml # .github/workflows/ai-moderator.lock.yml # .github/workflows/archie.lock.yml # .github/workflows/artifacts-summary.lock.yml # .github/workflows/audit-workflows.lock.yml # .github/workflows/blog-auditor.lock.yml # .github/workflows/brave.lock.yml # .github/workflows/breaking-change-checker.lock.yml # .github/workflows/campaign-generator.lock.yml # .github/workflows/campaign-manager.lock.yml # .github/workflows/changeset.lock.yml # .github/workflows/ci-coach.lock.yml # .github/workflows/ci-doctor.lock.yml # .github/workflows/cli-consistency-checker.lock.yml # .github/workflows/cli-version-checker.lock.yml # .github/workflows/cloclo.lock.yml # .github/workflows/close-old-discussions.lock.yml # .github/workflows/commit-changes-analyzer.lock.yml # .github/workflows/copilot-agent-analysis.lock.yml # .github/workflows/copilot-pr-merged-report.lock.yml # .github/workflows/copilot-pr-nlp-analysis.lock.yml # .github/workflows/copilot-pr-prompt-analysis.lock.yml # .github/workflows/copilot-session-insights.lock.yml # .github/workflows/craft.lock.yml # .github/workflows/daily-assign-issue-to-user.lock.yml # .github/workflows/daily-choice-test.lock.yml # .github/workflows/daily-code-metrics.lock.yml # .github/workflows/daily-copilot-token-report.lock.yml # .github/workflows/daily-copilot-token-report.md # .github/workflows/daily-doc-updater.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-file-diet.lock.yml # .github/workflows/daily-firewall-report.lock.yml # .github/workflows/daily-issues-report.lock.yml # .github/workflows/daily-malicious-code-scan.lock.yml # .github/workflows/daily-multi-device-docs-tester.lock.yml # .github/workflows/daily-news.lock.yml # .github/workflows/daily-performance-summary.lock.yml # .github/workflows/daily-repo-chronicle.lock.yml # .github/workflows/daily-team-status.lock.yml # .github/workflows/daily-workflow-updater.lock.yml # .github/workflows/deep-report.lock.yml # .github/workflows/dependabot-go-checker.lock.yml # .github/workflows/dev-hawk.lock.yml # .github/workflows/dev.lock.yml # .github/workflows/developer-docs-consolidator.lock.yml # .github/workflows/dictation-prompt.lock.yml # .github/workflows/docs-noob-tester.lock.yml # .github/workflows/duplicate-code-detector.lock.yml # .github/workflows/example-permissions-warning.lock.yml # .github/workflows/example-workflow-analyzer.lock.yml # .github/workflows/firewall-escape.lock.yml # .github/workflows/firewall.lock.yml # .github/workflows/github-mcp-structural-analysis.lock.yml # .github/workflows/github-mcp-tools-report.lock.yml # .github/workflows/glossary-maintainer.lock.yml # .github/workflows/go-fan.lock.yml # .github/workflows/go-file-size-reduction-project64.campaign.g.lock.yml # .github/workflows/go-logger.lock.yml # .github/workflows/go-pattern-detector.lock.yml # .github/workflows/grumpy-reviewer.lock.yml # .github/workflows/hourly-ci-cleaner.lock.yml # .github/workflows/human-ai-collaboration.lock.yml # .github/workflows/incident-response.lock.yml # .github/workflows/instructions-janitor.lock.yml # .github/workflows/intelligence.lock.yml # .github/workflows/issue-arborist.lock.yml # .github/workflows/issue-classifier.lock.yml # .github/workflows/issue-monster.lock.yml # .github/workflows/issue-triage-agent.lock.yml # .github/workflows/jsweep.lock.yml # .github/workflows/layout-spec-maintainer.lock.yml # .github/workflows/lockfile-stats.lock.yml # .github/workflows/mcp-inspector.lock.yml # .github/workflows/mergefest.lock.yml # .github/workflows/metrics-collector.lock.yml # .github/workflows/notion-issue-summary.lock.yml # .github/workflows/org-health-report.lock.yml # .github/workflows/org-wide-rollout.lock.yml # .github/workflows/pdf-summary.lock.yml # .github/workflows/plan.lock.yml # .github/workflows/playground-org-project-update-issue.lock.yml # .github/workflows/playground-snapshots-refresh.lock.yml # .github/workflows/poem-bot.lock.yml # .github/workflows/portfolio-analyst.lock.yml # .github/workflows/pr-nitpick-reviewer.lock.yml # .github/workflows/prompt-clustering-analysis.lock.yml # .github/workflows/python-data-charts.lock.yml # .github/workflows/q.lock.yml # .github/workflows/release.lock.yml # .github/workflows/repo-tree-map.lock.yml # .github/workflows/repository-quality-improver.lock.yml # .github/workflows/research.lock.yml # .github/workflows/safe-output-health.lock.yml # .github/workflows/schema-consistency-checker.lock.yml # .github/workflows/scout.lock.yml # .github/workflows/security-compliance.lock.yml # .github/workflows/security-fix-pr.lock.yml # .github/workflows/semantic-function-refactor.lock.yml # .github/workflows/slide-deck-maintainer.lock.yml # .github/workflows/smoke-claude.lock.yml # .github/workflows/smoke-codex-firewall.lock.yml # .github/workflows/smoke-codex.lock.yml # .github/workflows/smoke-copilot-no-firewall.lock.yml # .github/workflows/smoke-copilot-playwright.lock.yml # .github/workflows/smoke-copilot-safe-inputs.lock.yml # .github/workflows/smoke-copilot.lock.yml # .github/workflows/smoke-copilot.md # .github/workflows/smoke-detector.lock.yml # .github/workflows/smoke-srt-custom-config.lock.yml # .github/workflows/smoke-srt.lock.yml # .github/workflows/spec-kit-execute.lock.yml # .github/workflows/spec-kit-executor.lock.yml # .github/workflows/speckit-dispatcher.lock.yml # .github/workflows/stale-repo-identifier.lock.yml # .github/workflows/static-analysis-report.lock.yml # .github/workflows/sub-issue-closer.lock.yml # .github/workflows/super-linter.lock.yml # .github/workflows/technical-doc-writer.lock.yml # .github/workflows/tidy.lock.yml # .github/workflows/typist.lock.yml # .github/workflows/unbloat-docs.lock.yml # .github/workflows/video-analyzer.lock.yml # .github/workflows/weekly-issue-summary.lock.yml # .github/workflows/workflow-generator.lock.yml # .github/workflows/workflow-health-manager.lock.yml # .gitignore # Makefile # actions/setup/js/assign_copilot_to_created_issues.cjs # actions/setup/js/log_parser_shared.cjs # actions/setup/js/parse_claude_log.cjs # actions/setup/js/parse_codex_log.cjs # actions/setup/js/parse_copilot_log.cjs # actions/setup/js/parse_firewall_logs.cjs # actions/setup/js/validate_errors.cjs # actions/setup/setup.sh # pkg/cli/actions_build_command.go # pkg/workflow/bundler_integration_test.go # pkg/workflow/compiler_activation_jobs.go # pkg/workflow/compiler_safe_outputs_core.go # pkg/workflow/compiler_safe_outputs_specialized.go # pkg/workflow/compiler_yaml.go # pkg/workflow/compiler_yaml_ai_execution.go # pkg/workflow/compiler_yaml_helpers.go # pkg/workflow/compiler_yaml_main_job.go # pkg/workflow/copilot_participant_steps.go # pkg/workflow/copilot_srt.go # pkg/workflow/create_agent_task.go # pkg/workflow/create_issue.go # pkg/workflow/git_patch_head_test.go # pkg/workflow/jobs.go # pkg/workflow/js.go # pkg/workflow/js/log_parser_shared.test.cjs # pkg/workflow/js_test.go # pkg/workflow/maintenance_workflow.go # pkg/workflow/mcp_servers.go # pkg/workflow/missing_tool.go # pkg/workflow/missing_tool_test.go # pkg/workflow/notify_comment.go # pkg/workflow/pr.go # pkg/workflow/redact_secrets.go # pkg/workflow/repo_memory.go # pkg/workflow/role_checks.go # pkg/workflow/safe_inputs_http_integration_test.go # pkg/workflow/safe_outputs_cjs_extension_test.go # pkg/workflow/safe_outputs_mcp_integration_test.go # pkg/workflow/safe_outputs_steps.go # pkg/workflow/scripts.go # pkg/workflow/scripts_test.go # pkg/workflow/sh.go # pkg/workflow/template.go # pkg/workflow/template_rendering_test.go # specs/actions.md
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incomplete string escaping in bash command formatting
Merge main branch into security fix PR for Alert #83
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged main branch into the security fix PR while preserving the backslash escaping fix for CodeQL Alert #83.
Changes
pkg/workflow/js/log_parser_shared.cjsValidateDuplicateSteps()andextractStepName()from main intopkg/workflow/jobs.goto satisfy test dependenciesactions/setup/js/exclusion patternSecurity Fix Verification
The core security fix remains intact at line 138 of
pkg/workflow/js/log_parser_shared.cjs:This prevents the escaping bypass vulnerability where
\`` would become\`` (leaving the backtick unescaped) if backslashes weren't escaped first.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.