Fix TypeScript error handling in add_reaction_and_edit_comment.cjs #7810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_reaction_and_edit_comment.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests and run tests for add_reaction_and_edit_comment.cjs
Fix TypeScript error handling in add_reaction_and_edit_comment.cjs
Dec 26, 2025
pelikhan
merged commit 4e3d98b
into
jsweep-clean-add-reaction-and-edit-comment-36c6dd997570a6bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript compilation was failing due to improper error type handling in catch blocks. The optional chaining approach
error?.messagedoesn't satisfy TypeScript's type constraints whenerrorhas implicit{}type.Changes:
error instanceof Error ? error.message : String(error)patternThis aligns with the codebase's established error handling pattern used in
create_issue.cjs,create_pull_request.cjs, and other files.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.