Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 14, 2025

This PR removes the workflow_run trigger from the test workflow for missing tool safe outputs, simplifying the trigger configuration to only use manual execution.

Changes Made

  • Removed workflow_run trigger: The workflow previously triggered on completion of any workflow (workflows: ["*"] with types: [completed]), which could cause unnecessary executions
  • Updated documentation: Removed references to the workflow_run trigger from the workflow's documentation section
  • Recompiled workflow: Updated the corresponding .lock.yml file to reflect the trigger changes

Before

on:
  workflow_dispatch:
  workflow_run:
    workflows: ["*"]
    types: [completed]

After

on:
  workflow_dispatch:

Rationale

The workflow_run trigger was causing the test workflow to execute after every workflow completion in the repository, which is unnecessary for a test workflow focused on validating missing tool safe output functionality. The workflow is now triggered only via manual execution (workflow_dispatch), making it more predictable and reducing unnecessary workflow runs.

The test workflow's primary purpose is to validate the missing-tool safe output type functionality using a custom engine, and manual triggering is sufficient for this testing purpose.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.contoso.com
    • Triggering command: /tmp/go-build2366863216/b278/cli.test -test.testlogfile=/tmp/go-build2366863216/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
    • Triggering command: /tmp/go-build2628927492/b278/cli.test -test.testlogfile=/tmp/go-build2628927492/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] remove workflow_run from test safe output missing tool agentic workflow file Remove workflow_run trigger from test-safe-output-missing-tool workflow Sep 14, 2025
Copilot AI requested a review from pelikhan September 14, 2025 15:01
@pelikhan pelikhan marked this pull request as ready for review September 14, 2025 15:02
@pelikhan pelikhan merged commit 3019cd3 into main Sep 14, 2025
@pelikhan pelikhan deleted the copilot/fix-42508cb1-5745-49ef-9f53-62c965b6ae06 branch September 14, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants