Fail step when safe output handler doesn't return function #8348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler manager was logging a warning and continuing when handlers didn't return functions, causing silent failures where safe outputs were never processed.
Changes:
safe_output_handler_manager.cjs: Changed validation from warning to fatal errormain()doesn't return a functionsafe_output_handler_manager.test.cjs: Added test documentation for validation behaviorBefore:
After:
Handler
main()must follow factory pattern and return a message handler function. Handlers returningundefinedwill now fail loudly instead of silently skipping processing.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.