-
Notifications
You must be signed in to change notification settings - Fork 34
Warn when safe output messages are skipped due to missing handlers #8356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change debug logging to warning when safe output messages cannot be processed due to missing handlers. This ensures users are notified when their messages (like create_issue) are skipped because the handler was not loaded or configured. Changes: - Convert core.debug() to core.warning() for missing handlers - Add detailed warning message explaining the issue - Record skipped messages in results array for tracking - Update summary to separately count and report skipped messages - Add test case for missing handler scenario This fixes the issue where create_issue messages were silently skipped without any visible warning in the logs. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️ |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
Smoke Test Results - Run #20627741319Last 2 merged PRs:
Test Results:
Overall Status: PASS ✅ cc @pelikhan
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall Status: PASS
|
|
PRs: #8353 Fix JavaScript formatting in safe_output_handler_manager.test.cjs; #8352 Fix non-deterministic tool ordering in compiled workflows with imported safe-jobs
|
Smoke Test Results - Run 20627741318❌ Playwright MCP: Command not available in environment Overall Status:
|
|
GitHub MCP (last 2 merged PRs): #8353 "Fix JavaScript formatting in safe_output_handler_manager.test.cjs"; #8352 "Fix non-deterministic tool ordering in compiled workflows with imported safe-jobs".
|
When safe output messages (e.g.,
create_issue) are sent but no handler is loaded—typically due to missing workflow configuration—they were silently skipped with only a debug log invisible in standard GitHub Actions output.Changes
core.debug()tocore.warning()with actionable message pointing to safe-outputs configurationExample
Before:
After:
Reference: https://github.com/githubnext/gh-aw/actions/runs/20627369243/job/59240177309#step:6:1
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.