Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 2, 2026

Test suite failures after safe output handler manager consolidation and context cancellation support.

Changes

Safe output test expectations (safe_outputs_integration_test.go)

  • Updated TestConsolidatedSafeOutputsJobIntegration to expect process_safe_outputs step instead of individual create_issue/add_comment steps
  • Reflects handler manager consolidation where multiple safe output types are processed in a single step

Context parameter signatures (run_command_test.go)

  • Added context.Context as first parameter to all RunWorkflowOnGitHub and RunWorkflowsOnGitHub test calls
  • Aligns with context cancellation support added for artifact downloads

MCP server test parameters (mcp_server_*_test.go)

  • Corrected audit tool parameter from run_id to run_id_or_url in test fixtures
  • Matches actual MCP tool schema definition
// Before
params := &mcp.CallToolParams{
    Name: "audit",
    Arguments: map[string]any{
        "run_id": int64(1),
    },
}

// After
params := &mcp.CallToolParams{
    Name: "audit",
    Arguments: map[string]any{
        "run_id_or_url": "1",
    },
}

Test Status

  • ✅ All workflow package tests passing
  • ✅ 22/24 MCP server tests passing (91.7%)
  • ⚠️ 2 MCP compile tests with --cmd flag remain failing (pre-existing from commit 4b211c5)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@mnkiefer mnkiefer marked this pull request as ready for review January 2, 2026 20:24
mnkiefer and others added 3 commits January 2, 2026 21:41
- Fixed TestConsolidatedSafeOutputsJobIntegration to reflect handler manager consolidation
- Added context.Context parameter to RunWorkflowOnGitHub and RunWorkflowsOnGitHub calls in tests
- Updated expected step names to match actual behavior (process_safe_outputs instead of individual steps)

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Changed audit tool parameter from "run_id" to "run_id_or_url" in tests
- Fixed TestMCPServer_ErrorCodes_InternalError test
- Fixed TestMCPServer_AllToolsReturnContent test
- Improved test parameter correctness

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 2, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login 0.0.54 l/linux_amd64/link epo /usr/bin/git /home/REDACTED/go/add pkg/mod/golang.o.github/workflows/test.md gh api /repos/actions/checkout/git/ref/tags/v5.0.1 --jq /opt/hostedtoolcache/node/24.12.0/x64/bin/node /tmp/validate-jsgit e/git-remote-httrev-parse a6df73144a9ee2f2--show-toplevel node (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login it/ref/tags/v5 refs/tags/v4.6.2 /usr/bin/git /tmp/validate-jsgit /usr/lib/git-correv-parse g.test git rev-�� b/workflows g.test /opt/hostedtoolcache/node/24.12.json om/erlef/setup-binfocmp /&#34; &#43; .name ux-amd64/pkg/tooxterm-color node (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login /repos/actions/checkout/git/ref/remote.origin.url --jq 0d98bbad63f2a7e57dced9c61299d80010e/log.json om/actions/cacheinfocmp e/git-remote-htt-1 rg/toolchain@v0.xterm-color ine --ch�� ithub/workflows rg/toolchain@v0.-test.timeout=3m0s runs/20260102-203424-45371/test-2281132542/.gitattributes ingutil.test -f ux-amd64/pkg/toomoby sh (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Chore: Enhance campaign management features fix: update test expectations for handler manager and context parameters Jan 2, 2026
Copilot AI requested a review from mnkiefer January 2, 2026 21:02
@mnkiefer mnkiefer merged commit 4eebd84 into update-campaign-logic Jan 2, 2026
@mnkiefer mnkiefer deleted the copilot/sub-pr-8670 branch January 2, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants