-
Notifications
You must be signed in to change notification settings - Fork 34
Use MiniDot spinner style with ACCESSIBLE environment variable support #8787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add SpinnerStyle enum with 9 different spinner styles (Dot, Line, MiniDot, Points, Globe, Moon, Jump, Pulse, Ellipsis) - Add NewSpinnerWithStyle() function to create spinners with custom styles - Add ACCESSIBLE environment variable support to disable animations - Add comprehensive tests for all spinner styles and accessibility mode - Add package documentation explaining usage and accessibility - Maintain backward compatibility with existing NewSpinner() API Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Document all 9 available spinner styles with examples - Explain accessibility support with ACCESSIBLE env var - Show usage examples for default and custom styles - Document TTY detection behavior - Add visual examples of each spinner style Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
pkg/console/README.md
Outdated
|
|
||
| - `SpinnerDot` (default) - Braille dots: ⠋ ⠙ ⠹ ⠸ ⠼ ⠴ ⠦ ⠧ ⠇ ⠏ | ||
| - `SpinnerLine` - Simple line: | / - \ | ||
| - `SpinnerMiniDot` - Minimal dots: ⣾ ⣽ ⣻ ⢿ ⡿ ⣟ ⣯ ⣷ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Only support spinnerminidot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified to only support MiniDot spinner style in commit 5a3f93f. Removed all other spinner styles (Dot, Line, Points, Globe, Moon, Jump, Pulse, Ellipsis) and the NewSpinnerWithStyle() function. The NewSpinner() function now creates MiniDot spinners by default.
- Remove SpinnerStyle enum and all style variants (Dot, Line, Points, Globe, Moon, Jump, Pulse, Ellipsis) - Keep only MiniDot spinner style - Remove NewSpinnerWithStyle function - Update NewSpinner to use MiniDot by default - Simplify tests to remove style-specific tests - Update documentation to reflect single MiniDot style - Maintain ACCESSIBLE environment variable support Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot Lint |
Linting complete - all checks pass:
No code changes needed. |
The spinner implementation was already using Bubbles but only supported the Dot style and lacked accessibility controls. This changes the spinner to use MiniDot style and adds ACCESSIBLE environment variable support.
Changes
Spinner Style:
NewSpinner()creates MiniDot spinners - backward compatible APIAccessibility:
ACCESSIBLEenvironment variable is setTesting:
Documentation:
Usage
Files Modified
pkg/console/spinner.go- Simplified implementation with MiniDot and ACCESSIBLE supportpkg/console/spinner_test.go- Test coverage for core functionalitypkg/console/README.md- Spinner documentation with MiniDot styleOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.