-
Notifications
You must be signed in to change notification settings - Fork 34
Set default expiration on create discussion to 7 days #9234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
@copilot update JSON schema |
…ssion Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
January 7, 2026 14:27
Copilot stopped work on behalf of
pelikhan due to an error
January 7, 2026 14:31
Contributor
|
@copilot keep working |
Copilot stopped work on behalf of
pelikhan due to an error
January 7, 2026 14:44
Contributor
|
@copilot keep working |
…eate-discussion Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
[WIP] Set default expiration on create discussion to 7 days
Set default expiration on create discussion to 7 days
Jan 7, 2026
Contributor
|
@copilot merge main, lint |
…xpiration-discussion
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan: Set Default Expiration on create-discussion to 7d
parseDiscussionsConfig()functionExpiresto 168 hours (7 days) when not explicitly configuredChanges Made
Updated
pkg/workflow/create_discussion.go:expiresfield is not specified or is 0expiresfieldAdded tests in
pkg/workflow/create_discussion_dependencies_test.go:TestParseDiscussionsConfigDefaultExpirationto verify default behaviorUpdated
pkg/parser/schemas/main_workflow_schema.json:"default": 7to theexpiresfield forcreate-discussionRecompiled 35 workflow lock files:
create-discussionwithout explicitexpiresnow have default"expires":168in their configurationMerged main branch (commit 89cc3a8):
Verification
✅ All unit tests pass including the new tests
✅ Manual compilation test confirms default expiration is set correctly (verified via debug logs and compiled YAML)
✅ The default value (168 hours = 7 days) is properly passed to the JavaScript handler through
GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG✅ 35 workflow lock files updated with default expiration value
✅ JSON schema updated to document the default value
✅ Schema validation tests pass
✅ Merged with main branch successfully
✅ Linting passes
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.