Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 8, 2026

Remove errors and warnings support

This change removes the error pattern regex system and warning detection from the codebase.

Completed Changes

  • Go Code Changes

    • Remove ErrorPattern struct from pkg/workflow/agentic_engine.go
    • Remove GetErrorPatterns() method from engine interface and implementations
    • Remove GetCommonErrorPatterns() function
    • Remove error pattern parsing in engine.go
    • Remove error validation step generation in compiler_yaml_ai_execution.go
    • Remove CountErrorsAndWarningsWithPatterns() from metrics.go
    • Remove LogError struct and related functions from metrics.go
    • Update LogMetrics struct to remove Errors field
    • Update compiler to skip error validation step
    • Update engine logs (copilot, codex, claude) to not use error patterns
    • Update logs parsing fallback to not use error patterns
    • Update audit command to remove errors/warnings display
    • Update logs command to remove errors/warnings from reports
    • Update copilot_agent to remove error extraction
    • Build successful
    • Remove error pattern specific test files
    • Fix all remaining test files to remove error/warning references
    • Tests compiling and running
    • Go linting passing - Fixed all syntax errors and removed unused functions
    • Merged main branch - Successfully merged latest changes from main
  • JavaScript Changes

    • Remove validate_errors.cjs and its test file
    • JavaScript linting passing - All .cjs, .ts, and .json files properly formatted
  • Testing

    • Fixed all test files that referenced LogError and error patterns
    • Removed dedicated error pattern test files
    • Updated test expectations to not check for error/warning counts
    • Tests are now building and running

Summary

All error pattern regex support has been completely removed from:

  • Workflow engine interface and implementations (Copilot, Claude, Codex)
  • Compiler YAML generation (no more error validation steps)
  • Metrics collection and logging
  • CLI commands (audit, logs)
  • JavaScript validation scripts
  • All test files

The codebase is now:

  • Fully merged with main branch
  • Fully linted (Go and JavaScript)
  • Building successfully
  • Ready for merge
Original prompt

Remove errors and warnings support in Go and JavaScript.

  • remove error pattern regexes
  • remove JavaScript parser
  • remove compiler support
  • remove error/warning in logs/audit

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits January 8, 2026 04:37
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove errors and warnings support in Go and JavaScript Remove error pattern regex validation system Jan 8, 2026
Copilot AI requested a review from pelikhan January 8, 2026 05:03
@pelikhan
Copy link
Contributor

pelikhan commented Jan 8, 2026

@copilot keep removing log errors and warnings

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot keep removing log errors and warnings

Completed removal of all log errors and warnings support:

  • Removed LogError struct and error pattern functionality from core engine
  • Removed error/warning counting from all CLI commands (audit, logs)
  • Fixed 20+ test files that referenced error patterns
  • Removed 13 test files dedicated to error pattern testing

All error and warning detection has been removed from the codebase. Commit: 027de2e

@pelikhan pelikhan marked this pull request as ready for review January 8, 2026 05:51
@pelikhan
Copy link
Contributor

pelikhan commented Jan 8, 2026

@copilot lint go

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Contributor

pelikhan commented Jan 8, 2026

@copilot lint go

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot lint go

Go linting now passes successfully. Fixed:

  • Syntax errors in test files (missing braces)
  • Removed ErrorPattern references from metrics_test.go
  • Removed unused functions in logs_report.go (aggregateLogErrors, isActionableError, buildErrorsSummary)

All linting checks passing. Commit: 96b9f06

@pelikhan
Copy link
Contributor

pelikhan commented Jan 8, 2026

@copilot format, lint js

Copy link
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot format, lint js

JavaScript formatting and linting already passing:

  • All .cjs, .ts, and .json files properly formatted with Prettier
  • All JavaScript linting checks pass

No changes needed.

@pelikhan
Copy link
Contributor

pelikhan commented Jan 8, 2026

@copilot merge main, lint go, lint js

Copilot AI and others added 2 commits January 8, 2026 06:45
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot merge main, lint go, lint js

Completed successfully:

  • ✅ Merged main branch (136 files changed from main)
  • ✅ Go linting passing (fixed staticcheck issue in compiler_jobs.go)
  • ✅ JavaScript linting passing (formatted runtime_import.test.cjs)

All checks passing. Commit: ed10b34

@pelikhan pelikhan merged commit 8c9952e into main Jan 8, 2026
79 checks passed
@pelikhan pelikhan deleted the copilot/remove-error-support-go-js branch January 8, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants