Centralize workflow filename manipulation and file type detection into helper functions

[Copilot]

The codebase had 250+ instances of manual string manipulation for workflow filename transformations (.md ↔ .lock.yml, campaign specs, etc.) scattered across files, making maintenance error-prone and inconsistent. Additionally, file type detection logic using strings.HasSuffix() was duplicated throughout the codebase.

Changes

Created centralized helpers in pkg/stringutil/identifiers.go:

Filename Transformations:

• MarkdownToLockFile() - .md → .lock.yml
• LockFileToMarkdown() - .lock.yml → .md
• CampaignSpecToOrchestrator() - .campaign.md → .campaign.g.md
• CampaignOrchestratorToLockFile() - .campaign.g.md → .campaign.lock.yml
• CampaignSpecToLockFile() - .campaign.md → .campaign.lock.yml

File Type Detection:

• IsCampaignSpec() - Detects campaign specification files (.campaign.md)
• IsCampaignOrchestrator() - Detects campaign orchestrator files (.campaign.g.md)
• IsAgenticWorkflow() - Detects agentic workflow files (.md excluding campaigns)
• IsLockFile() - Detects compiled lock files (.lock.yml)
• IsCampaignLockFile() - Detects campaign lock files (.campaign.lock.yml)

Replaced patterns across 119 files:

• strings.TrimSuffix(path, ".md") + ".lock.yml" → stringutil.MarkdownToLockFile(path)
• strings.Replace(path, ".md", ".lock.yml", 1) → stringutil.MarkdownToLockFile(path)
• Campaign-specific transformations → dedicated helpers

Examples

Filename Transformation - Before:

lockFile := strings.TrimSuffix(markdownPath, ".md") + ".lock.yml"
if strings.HasSuffix(markdownPath, ".campaign.g.md") {
    baseName := strings.TrimSuffix(markdownPath, ".campaign.g.md")
    lockFile = baseName + ".campaign.lock.yml"
}

Filename Transformation - After:

var lockFile string
if strings.HasSuffix(markdownPath, ".campaign.g.md") {
    lockFile = stringutil.CampaignOrchestratorToLockFile(markdownPath)
} else {
    lockFile = stringutil.MarkdownToLockFile(markdownPath)
}

File Type Detection - Before:

if strings.HasSuffix(path, ".campaign.md") {
    // handle campaign spec
}

File Type Detection - After:

if stringutil.IsCampaignSpec(path) {
    // handle campaign spec
}

All helpers include comprehensive tests with round-trip validation and exclusivity testing to ensure file types are correctly distinguished.

Original prompt

Refactor and centralize all the workflow filename manipulator code into helper functions in .go

Search for any ".lock.yml", ".md" string literals, look for workflow name to id, id to filename etc...

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[pelikhan]

@copilot also refactor helpers to determine if a file is a campaign or a compiled agentic campaign workflow or a agentic workflow or a lock file

[Copilot]

@copilot also refactor helpers to determine if a file is a campaign or a compiled agentic campaign workflow or a agentic workflow or a lock file

Added 5 file type detection helpers in commit fcc9f41:

• IsCampaignSpec(path) - Detects .campaign.md files
• IsCampaignOrchestrator(path) - Detects .campaign.g.md files
• IsAgenticWorkflow(path) - Detects .md files (excluding campaigns)
• IsLockFile(path) - Detects .lock.yml files
• IsCampaignLockFile(path) - Detects .campaign.lock.yml files

All helpers include comprehensive tests with exclusivity validation to ensure file types are correctly distinguished.