-
Notifications
You must be signed in to change notification settings - Fork 36
Add host.docker.internal to Codex default domains for MCP gateway access #9999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Fixes DNS resolution failure when Codex agent tries to connect to MCP Gateway via host.docker.internal from within AWF container. Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Status: FAIL (serena-go unavailable) cc @Mossaka
|
Smoke Test ResultsPRs:
Tests:
Status: PARTIAL PASS (5/6 tests passed, Serena Go unavailable)
|
|
The codex test tried to connect to an MCP server and got: Codex's reqwest library has DNS resolution issues Can you think of a solution to workaround of it without compromising the security posture of awf and the gateway? |
When using `tools.github.mode: remote`, the Codex agent needs to connect to api.githubcopilot.com. This wasn't being added to the firewall allowlist because the URL is set internally, not in the raw frontmatter. - Add GitHubCopilotMCPDomain constant - Detect `mode: remote` in extractHTTPMCPDomains and add the domain - Add tests for GitHub MCP remote/local mode domain extraction Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Fixed in 558cd2d. The issue was that when using
Solution: Enhanced This maintains the security posture - only the specific remote MCP domain is allowed, not arbitrary domains. |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
@copilot fix this run failure: https://github.com/githubnext/gh-aw/actions/runs/21048249052/job/60528124113?pr=9999 |
|
PRs: Add JSON output and DEBUG logging to OpenCode engine; Remove incorrect PATH setup for OpenCode npm global installation
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall Status: FAIL (1/5 tests failed) cc @Mossaka
|
Smoke Test Results - Claude EngineRecent PRs:
Test Results:
Status: PARTIAL PASS (5/6)
|
The loadAgentOutput function was changed to use core.info instead of core.error for missing files (see #10128). This is a normal scenario when the agent fails before producing safe-outputs, so info-level logging is appropriate. Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Fixed in 8665727. The Note: The other test failures ( |
- Add 30 second timeout to all Go tests (was 10s default) - Go compilation in CI can be slow - Fixes test timeout failures in CI
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results (Run #21049334863)Last 2 Merged PRs:
Test Results:
Overall Status: FAIL (1 test failed) cc @Mossaka
|
|
Smoke Test Results Last 2 merged PRs:
✅ GitHub MCP Status: PASS (5/6 tests passed)
|
|
Merged PRs:
|
host.docker.internalto connect to MCP GatewayCodexDefaultDomainsmissinghost.docker.internal(unlike Copilot/Claude defaults)host.docker.internaltoCodexDefaultDomainsinpkg/workflow/domains.goTestCodexDefaultDomainstest to expect the new domainTestGetCodexAllowedDomainstest to includehost.docker.internalin expected outputGitHubCopilotMCPDomainconstant inpkg/constants/constants.gomode: remoteinextractHTTPMCPDomainsand addapi.githubcopilot.com--sandbox danger-full-accessflag to Codex CLI invocationOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
host.docker.internalto Codex default domains; fix MCP gateway domain extraction for remote mode; update related tests and add Codex CLI sandbox flag to allow full access when running inside AWF. Fixes Codex agent unable to use MCP tools due to host.docker.internal DNS resolution failure #9998