Skip to content

Restore benchmarks results page#257

Merged
mrjf merged 2 commits into
mainfrom
copilot/restore-benchmarks-page
Apr 30, 2026
Merged

Restore benchmarks results page#257
mrjf merged 2 commits into
mainfrom
copilot/restore-benchmarks-page

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

playground/benchmarks.html was unintentionally converted into a generic interactive playground by commit d0b6262 ("Standardize all playground pages and add conformance tests"), losing the tsb-vs-pandas results table that aggregates every benchmark.

Changes

  • playground/benchmarks.html — Restored to the pre-d0b6262 version: the "Detailed Results" table (function, tsb ms, pandas ms, ratio, faster) populated from benchmarks/results.json, plus the Methodology and About panels.
  • tests/playground.test.ts — Added benchmarks.html to NON_PLAYGROUND_PAGES so the playground-conformance suite skips it, alongside the existing index.html exemption. This is what previously pressured the page into the playground shape.
const NON_PLAYGROUND_PAGES = new Set<string>([
  "index.html",
  // The benchmarks page is a results chart (tsb vs pandas), not a playground.
  "benchmarks.html",
]);

Not changed

The earlier removal of the "Visual Comparison" bar chart (commit 1172c14) is left as-is — the issue refers to "the chart … where we listed every single benchmark", which is the results table restored here. Happy to also revert 1172c14 if the bar chart was in fact what was meant.

Copilot AI linked an issue Apr 30, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Revert changes to restore benchmarks page Restore benchmarks results page Apr 30, 2026
Copilot AI requested a review from mrjf April 30, 2026 21:20
Copilot finished work on behalf of mrjf April 30, 2026 21:20
@mrjf mrjf marked this pull request as ready for review April 30, 2026 21:23
@mrjf mrjf merged commit 842e631 into main Apr 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We lost our benchmarks page

2 participants