Skip to content

Fix flaky strRemovePrefix property test asserting wrong invariant #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrjf merged 2 commits into from
May 11, 2026
Merged

Fix flaky strRemovePrefix property test asserting wrong invariant #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7222399
Initial plan
Copilot May 10, 2026
f2382d1
Fix flaky strRemovePrefix property test
Copilot May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/stats/string_ops.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,11 +352,12 @@ describe("strNormalize — properties", () => {
});

describe("strRemovePrefix — properties", () => {
it("result never starts with prefix (when prefix non-empty)", () => {
it("removes exactly one occurrence of prefix when present, else returns str unchanged", () => {
fc.assert(
fc.property(fc.asciiString(), fc.asciiString({ minLength: 1 }), (str, prefix) => {
const result = strRemovePrefix(str, prefix);
return !(result.startsWith(prefix) && str.startsWith(prefix));
// Mirrors Python's str.removeprefix(): strips at most one leading occurrence.
return str.startsWith(prefix) ? prefix + result === str : result === str;
}),
);
});
Expand Down
Loading