Merged
Conversation
mattrothenberg
commented
Sep 1, 2022
Comment on lines
+37
to
+39
| "extensionDependencies": [ | ||
| "vscode.git" | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
While this isn't strictly necessary, I like calling out explicitly that we're using the native Git extension.
| await gitClient.waitForRepo(3) | ||
|
|
||
| // Next, let's grab the repo name. | ||
| await gitClient.waitForRepo() |
Contributor
Author
There was a problem hiding this comment.
We only ever call waitForRepo here... As such, I removed the "# of times" argument from the function and co-located it in the function implementation itself.
| return new Promise((resolve, reject) => { | ||
| let interval = setInterval(() => { | ||
| try { | ||
| const remotes = this.repository._repository.remotes |
Contributor
Author
There was a problem hiding this comment.
This was no longer returning the right data
Comment on lines
-122
to
-125
| export interface CommitOptions { | ||
| all?: boolean | 'tracked' | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Outdated type defs.
Closed
jaked
approved these changes
Sep 2, 2022
jaked
left a comment
jaked
left a comment
There was a problem hiding this comment.
approving on faith—cool to see a little of how it works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #23, folks are having trouble opening Flat Editor and it's crashing with a Git error.
After digging into (and reproducing locally) the issue, it seems like the Git VSCode extension API changed somewhere along the way, and some of the methods we were using no longer returned the correct data.
I've added the latest and greatest Git type definitions from VSCode and removed a few unused paths in our VSCodeGit class