Display only real branch name, not "refs/heads"

[brianamarie]

While going through learning lab with the participants in training this week, I saw that when opening a pull request, it shows "refs/heads" in addition to the branch name.

This pull request attempts to fix that. I haven't tested locally so I would ❤️ some review if anyone has time to get to it before I do.

cc @hectorsector @githubtraining/learning-engineering

[ghost]

No issues with your course have been found! You are good to go 🚀

[heiskr]

Awesome! I noticed the same thing in #11

[JasonEtco]

Nice catch @brianamarie 👌 Looking at this diff, my immediate understanding is that the code is right before. Calling | replace(THING_TO_REPLACE, THING_TO_REPLACE_WITH) is what we want - that said, its obviously not doing it. I'll play around and let you know what I find out 👍

[ghost]

No issues with your course have been found! You are good to go 🚀

[JasonEtco]

Since the switch to Liquid as the templating engine for responses, we can use the remove filter which does exactly what we want. I think that'll do it @brianamarie, but its worth testing to be sure.

[brianamarie]

I am not sure if I will have bandwidth to test this this week, but I'd like to. @hectorsector @ppremk or other @githubtraining/learning-engineering if you have the bandwidth to test this, that would be very helpful to getting this merged 👍

[brianamarie]

@hectorsector @githubtraining/learning-engineering Is there anything I can do to help, (other than test which I'm not sure how to do)?

[hectorsector]

Tested on my local LL instance and it checks out. Check here if you'd like to see the comment.

[brianamarie]

Thank you @hectorsector!