This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Conversation
Contributor
Author
|
@hectorsector @JasonEtco Do you know how I can reference the URL to the pages site correctly? I've commented by the line that needs changed, but I'm not sure the right way to do it. |
Contributor
Author
|
This is ready for review! I'd like to 🚢 with 1 👍 but will consider merging without review to make sure this can be on ghe tomorrow. cc @githubtraining/learning-engineering @githubtraining/trainers for 👀 |
crichID
approved these changes
May 9, 2019
Contributor
crichID
left a comment
crichID
left a comment
There was a problem hiding this comment.
@brianamarie I tested on .com and it looks good! I'm excited that it even applies my cname 😉
Contributor
|
I'm going to go ahead and merge this in under the assumption that @brianamarie has already 🍰 |
crichID
added a commit
that referenced
this pull request
Feb 7, 2020
Update URLs to be correct on GHES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the URLs for several responses so they will also work on GHES.
cc @JasonEtco as this uses the new
{{ repoUrl }}variable.cc @githubtraining/learning-engineering, @githubtraining/trainers