This repository was archived by the owner on Sep 1, 2022. It is now read-only.
QA fixes - second attempt #134
Merged
brianamarie merged 3 commits intomasterfrom May 13, 2019
Merged
Conversation
Contributor
|
Confirmed that I can move past the first step. Resuming testing now for the rest of the course and on GHE. |
hectorsector
approved these changes
May 12, 2019
Contributor
There was a problem hiding this comment.
Tested on GHE:
- the dependency graph and vulnerability alert does not load
- the rest of the course and its links work.
- I also changed the language about the ✏️ icons in the Files Changed tab for compatibility with Dotcom. However, on GHE the ✏️ still exists so the instructions don't make sense for those users.
Contributor
Author
|
Awesome, thank you so much @hectorsector! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second attempt to introduce the QA fixes. These were originally introduced in #130, but then when I tested in production with GitHub Teacher, the course wouldn't move past the first step.
I reverted in #133.
I am still unable to get the course to move past the first step with GitHub Teacher so I don't think these changes are problematic, but I'm going to leave them in this PR until Monday and focus on why the course won't move forward.