Skip to content

Minor tweaks to file creation activity#35

Merged
crichID merged 1 commit intomasterfrom
opening-files
Aug 23, 2017
Merged

Minor tweaks to file creation activity#35
crichID merged 1 commit intomasterfrom
opening-files

Conversation

@crichID
Copy link
Copy Markdown
Contributor

@crichID crichID commented Jul 19, 2017

@githubtraining/trainers my first commit ended up directly on master 😞 so this is technically the second commit on this file.

The changes included:

  • Remove the first line in the activity that instructs the students to find a meme they want to caption. The meme is randomly assigned when the script creates the files.
  • Add instructions for how to open files directly from the command line using Atom and VS Code.

This PR only includes some changes I made to the second bullet because I didn't want to end with code . followed by a period. You can see the other changes here: ac31865.

Question: Should we also include something to the effect of -- some additional setup may be required on your machine for these to work? Or leave it alone?

@hectorsector
Copy link
Copy Markdown
Contributor

Should we also include something to the effect of -- some additional setup may be required on your machine for these to work? Or leave it alone?

My experience working with people tells me they won't read something so subtle 🤷‍♂️

@beardofedu
Copy link
Copy Markdown
Member

Question: Should we also include something to the effect of -- some additional setup may be required on your machine for these to work? Or leave it alone?

I don't think we need to identify that some setup might be required. I also agree with @hectorsector that most people will miss that subtle note. We tend to shy away from discussing configuring an editor for Git in class, so, letting them know that VS Code and Atom can be used directly from the terminal might be enough to get them to go-go-google.

Copy link
Copy Markdown
Contributor

@brianamarie brianamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

Copy link
Copy Markdown
Contributor

@hollenberry hollenberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, too! I would personally add that warning note just to cover our bases, but I agree with @hectorsector and @beardofedu that it's unlikely to be read.

@crichID
Copy link
Copy Markdown
Contributor Author

crichID commented Aug 23, 2017

👋 team -- thank you for the quick 👀 and 👍s. I will go ahead and 🚢 this now!

@crichID crichID merged commit 7ae60b1 into master Aug 23, 2017
@crichID crichID deleted the opening-files branch August 23, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants