-
Notifications
You must be signed in to change notification settings - Fork 327
[WIP] Add New Graphics #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hollenberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JasonEtco These are great!
- Passing thought for book/img/clone-branch-fork.png: Would it be possible to put the repository image inside the image of the monitor?
- I love the use of the images for fork and branch from the UI.
- In looking at Git Bisect, I'm wondering if it would be possible to switch the view to be horizontal. In the GitHub visualization tool, history is displayed horizontally and it might help comprehension to keep that consistent.
- Nice work!
I'd rather keep the icons separate (rather than composing new ones) but I see what you're after here; I'll do something along those lines 👍 |
|
Note that I'm adding these images, but I'm not including them or linking to them anywhere. @brianamarie @hollenberry y'all will need to figure this out 👍 |
|
@githubtraining/trainers I have incorporated @JasonEtco's ✨ graphics into the manual, both inline and with an appendix on forking. Your review would be greatly appreciated, specifically on:
|
hollenberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianamarie Built locally and this looks good. One thought: what do you think about moving the fork and pull section to just before Workflow Review, in section 3?
@hollenberry My understanding is that we don't always cover Fork and Pull. If the customer isn't using Fork and Pull, we will just use the script to generate their own repositories and we won't really get into Fork and Pull at all. Is this correct? |
|
👋 @brianamarie . That's my understanding as well. Is the scripted step our default/expected path, as opposed to Fork + Pull? My understanding is that we often pick one or the other based on customer, but I'm not sure which is most consistent. For those using the manual outside of a class with script permissions, a link to the appendix might be valuable. |
👍 This sounds like a good solution. I'm pushing up a commit doing just that. What do you think? |
7f4bd5f to
97f1289
Compare
|
Works for me. I'm still lacking clarity on default class approaches, but this can ship without that. 👍 |
I agree 👍 I think more clarity here would be good. |
@hollenberry @brianamarie should we open an issue to discuss this and perhaps put a team meeting label on it? |
This PR adds a number of new graphics to the training-manual courses. Will close #47.
git bisectgit resetcc @githubtraining/trainers