This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Update branch name #51
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,9 @@ | ||||||
| You can commit this suggestion directly. | ||||||
|
|
||||||
| ```suggestion | ||||||
| - uses: actions/download-artifact@main | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| with: | ||||||
| name: webpack artifacts | ||||||
| path: public | ||||||
| - name: npm install, and test | ||||||
| ``` | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,7 +32,7 @@ _You can follow the manual steps below, or accept the suggestions in the followi | |||||
| ... | ||||||
| steps: | ||||||
| - uses: actions/checkout@v2 | ||||||
| - uses: actions/download-artifact@main | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| with: | ||||||
| name: webpack artifacts | ||||||
| path: public | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,8 @@ Our custom workflow now accounts for: | |
| ---- | ||
|
|
||
| In the next few steps, we'll finish supporting our team's workflow: | ||
| - **branch protections** so that the `main` branch can't be deleted or inadvertently broken | ||
| - **required reviews** so that any pull requests are double checked by teammates | ||
| - **obvious approvals** so we can merge quickly and potentially automate merges and deployments | ||
|
|
||
| I'll respond when you merge this pull request. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ Remember the [custom workflow]({{ workflowIssue }}) we are attempting to create | |
| - :white_check_mark: **test against multiple targets** so that we know if our supported operating systems and Node.js versions are working | ||
| - :white_check_mark: **dedicated test job** so that we can separate out build from test details | ||
| - :white_check_mark: **access to build artifacts** so that we can deploy them to a target environment | ||
| - **branch protections** so that the `main` branch can't be deleted or inadvertently broken | ||
| - **required reviews** so that any pull requests are double checked by teammates | ||
| - **obvious approvals** so we can merge quickly and potentially automate merges and deployments | ||
|
|
||
|
|
@@ -23,4 +23,4 @@ GitHub Actions can run multiple workflows for different event triggers. Let's cr | |
| name: Team awesome's approval workflow | ||
| ``` | ||
|
|
||
| I'll respond when you commit to this branch. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,15 +1,15 @@ | ||||||
| ### Step 17: Hint | ||||||
|
|
||||||
| 1. Edit the [workflow file]({{ editUrl }}) on this branch. | ||||||
| 1. Give your step a name, have it use `pullreminders/label-when-approved-action@main`, and set all the required environment variables. | ||||||
| ```suggestion | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Label when approved | ||||||
| uses: pullreminders/label-when-approved-action@main | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| env: | ||||||
| APPROVALS: "1" | ||||||
| GITHUB_TOKEN: {% raw %}${{ secrets.GITHUB_TOKEN }}{% endraw %} | ||||||
| ADD_LABEL: "approved" | ||||||
| ``` | ||||||
| 1. Commit your changes to this branch. | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ Awesome! We can now check an additional requirement off our list! | |
| - :white_check_mark: **dedicated test job** so that we can separate out build from test details | ||
| - :white_check_mark: **access to build artifacts** so that we can deploy them to a target environment | ||
| - :white_check_mark: **obvious approvals** so we can merge quickly and potentially automate merges and deployments | ||
| - **branch protections** so that the `main` branch can't be deleted or inadvertently broken | ||
| - **required reviews** so that any pull requests are double checked by teammates | ||
|
|
||
| We'll now use branch protections in combination with this change so that everything goes smoothly. Up until now, I've handled branch protections for you, but I've removed them so that you can learn how to set them. | ||
|
|
@@ -21,11 +21,11 @@ Protected branches ensure that collaborators on your repository cannot make irre | |
|
|
||
| Next, add branch protections and continue with the course. | ||
|
|
||
| ### :keyboard: Activity: Complete the automated review process by protecting the main branch | ||
|
|
||
| 1. Go to [**Branches**]({{ settingsUrl}}/branches) settings. You can navigate to that page manually by clicking on the right-most tab in the top of the repository called **Settings** and then clicking on **Branches**. | ||
| 2. Click on [**Add rule**]({{ settingsUrl }}/branch_protection_rules/new) under "Branch protection rules". | ||
| 3. Type `main` in **Branch name pattern**. | ||
| 4. Check **Require pull request reviews before merging**. | ||
| 5. Check **Require status checks to pass before merging**. | ||
| 6. Check all build and test jobs that you'd like to see in the newly visible gray box. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ Nice work, you did it! Your workflows now contain: | |
| - :white_check_mark: **test against multiple targets** so that we know if our supported operating systems and Node.js versions are working | ||
| - :white_check_mark: **dedicated test job** so that we can separate out build from test details | ||
| - :white_check_mark: **access to build artifacts** so that we can deploy them to a target environment | ||
| - :white_check_mark: **branch protections** so that the `main` branch can't be deleted or inadvertently broken | ||
| - :white_check_mark: **required reviews** so that any pull requests are double checked by teammates | ||
| - :white_check_mark: **obvious approvals** so we can merge quickly and potentially automate merges and deployments | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.