fix(notifications): drop subject type suffix from native notification body - #3113
Merged
Conversation
|
setchy
approved these changes
Jul 29, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the
[subject type]suffix from the body of native OS notifications for a single notification, leaving just the subject title. The repository name stays as the notification title.Before:
some/repo—Fix the thing [PullRequest]After:
some/repo—Fix the thingThis trims the part of #3058 that appended the subject type; the repository name in the title (the more useful half of that change) is untouched.
Tests
The existing assertion used
expect.stringContaining(subject.title), which passes either way and so did not actually cover the body format. Tightened it to an exact match, verified it fails without the source change and passes with it.Full suite (1198 tests),
pnpm checkandtsc --noEmitall pass.