Skip to content

feat(settings): make close-to-tray the default and remove the option#2852

Merged
afonsojramos merged 1 commit intomainfrom
remove-close-to-tray-option
May 8, 2026
Merged

feat(settings): make close-to-tray the default and remove the option#2852
afonsojramos merged 1 commit intomainfrom
remove-close-to-tray-option

Conversation

@afonsojramos
Copy link
Copy Markdown
Member

@afonsojramos afonsojramos commented May 8, 2026

Summary

Removes the "Close to tray" checkbox added in #2845 and makes the hide-on-close behavior the default on every platform. Window-manager close requests (Cmd+W, Alt+F4, Super+Q) now always hide Gitify to the tray instead of quitting; explicit quits via the tray menu, Cmd/Ctrl+Q, or before-quit still tear the app down. Drops the related IPC event, preload API, comms wrapper, settings state, and renderer wiring (-148 net lines).

Test plan

  • WM close shortcut hides the popup; tray icon stays; clicking the tray reopens the same window with state intact
  • Tray right-click → "Quit Gitify" exits the app
  • Ctrl/Cmd+Q exits the app
  • Esc still hides the popup
  • pnpm test passes (window.test.ts trimmed; Settings snapshot regenerated)

@github-actions github-actions Bot added the enhancement New feature or enhancement to existing functionality label May 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@afonsojramos afonsojramos merged commit 4efc164 into main May 8, 2026
27 checks passed
@afonsojramos afonsojramos deleted the remove-close-to-tray-option branch May 8, 2026 12:41
@github-actions github-actions Bot added this to the Release 7.0.0 milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

2 participants