fix: increase polling interval for GitHub device code flow#2899
Merged
setchy merged 1 commit intoMay 17, 2026
Merged
Conversation
ChaosZ-1702
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
setchy
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2867 where the GitHub device auth flow gets stuck and gets rate-limited with
excessive requestsdue to the app ignoringslow_downresponses from the GitHub API.According to RFC 8628, when a
slow_downerror is received, the polling interval must be increased by 5 seconds.Changes
flows.ts: Differentiated theauthorization_pendingandslow_downinpollGitHubDeviceFlow. Whenslow_down,session.intervalSecondsis now incremented by 5.LoginWithDeviceFlow.tsx: MovedintervalMsinside the polling loop to ensure that any adjustments made tosession.intervalSecondsby the API response are immediately applied to the next cycle.flows.test.ts: Updated the tests to explicitly verify that the interval remains unchanged onauthorization_pendingand correctly increases by 5 onslow_down.