Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"GitLens: Open File on Remote" opens wrong Bitbucket URL #1006

Closed
halilim opened this issue Apr 22, 2020 · 5 comments
Closed

"GitLens: Open File on Remote" opens wrong Bitbucket URL #1006

halilim opened this issue Apr 22, 2020 · 5 comments
Assignees
Labels
bug Something isn't working verified Indicates that the issue has been community verified
Milestone

Comments

@halilim
Copy link

halilim commented Apr 22, 2020

  • GitLens Version: 10.2.1
  • VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:07:18.473Z)
  • OS version: Darwin x64 19.4.0

Steps to Reproduce:

  1. git clone https://bitbucket.org/atlassian/bitbucket-server-example-plugins.git
    cd bitbucket-server-example-plugins
    git checkout release/4.0
    code .
    
  2. Open .gitignore and select lines 2 & 3
  3. Cmd+Shift+P > GitLens: Open File on Remote

Actual:

https://bitbucket.org/atlassian/bitbucket-server-example-plugins/src/release/4.0/.gitignore#.gitignore-2:3 (404)

Expected:

https://bitbucket.org/atlassian/bitbucket-server-example-plugins/src/df3d81742268cd6ce91b1bc53d8611d701aab2fc/.gitignore?at=release%2F4.0#lines-2:3

@halilim halilim added the potential-bug Seems like something isn't working label Apr 22, 2020
@halilim halilim changed the title GitLens: Open File on Remote opens wrong Bitbucket URL "GitLens: Open File on Remote" opens wrong Bitbucket URL Apr 22, 2020
@nerdmax
Copy link

nerdmax commented Sep 15, 2020

The issue is, gitlen is composing the URL with the branch name, while bitbucket wants the commit id.

So, if we change the URL's branch name(release/4.0) to commit id(df3d81742268cd6ce91b1bc53d8611d701aab2fc), it will work.

e.g.:
bitbucket.org/atlassian/bitbucket-server-example-plugins/src/release/4.0/.gitignore#.gitignore-2:3 not working
https://bitbucket.org/atlassian/bitbucket-server-example-plugins/src/df3d81742268cd6ce91b1bc53d8611d701aab2fc/.gitignore#.gitignore-2:3 working fine

Can we confirm this and fix that for the repo that hosted in bitbucket?

@eamodio eamodio self-assigned this Feb 1, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug Seems like something isn't working labels Feb 1, 2021
@eamodio eamodio added this to the Soon™ milestone Feb 1, 2021
@eamodio eamodio closed this as completed in 6effd60 Feb 1, 2021
@eamodio eamodio added pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition needs-verification Indicates a request for community verification labels Feb 1, 2021
@eamodio
Copy link
Member

eamodio commented Feb 1, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@halilim
Copy link
Author

halilim commented Feb 2, 2021

Can confirm v11.2.0 fixed it (should I still check the insider edition?). Thanks!

@eamodio
Copy link
Member

eamodio commented Feb 2, 2021

@halilim Nope, thanks so much!

@eamodio eamodio added verified Indicates that the issue has been community verified and removed needs-verification Indicates a request for community verification labels Feb 2, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
@eamodio eamodio removed the pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition label Feb 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified Indicates that the issue has been community verified
Projects
None yet
Development

No branches or pull requests

3 participants