Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to turn off "Show Branch" tooltip in terminal #1284

Closed
tgreen7 opened this issue Dec 21, 2020 · 6 comments
Closed

Ability to turn off "Show Branch" tooltip in terminal #1284

tgreen7 opened this issue Dec 21, 2020 · 6 comments
Assignees
Labels
feature New feature or request verified Verified
Milestone

Comments

@tgreen7
Copy link

tgreen7 commented Dec 21, 2020

I like to copy the current git branch name by double clicking it in my integrated terminal. However, gitlens is creating a tooltip on the branch name on hover which breaks my double click selection.

Screen Shot 2020-12-21 at 12 33 25 PM

Where is this code coming from? Is it possible to turn this off?

@tgreen7 tgreen7 added feature New feature or request triage Needs to be looked at labels Dec 21, 2020
@eamodio eamodio removed the triage Needs to be looked at label Dec 22, 2020
@eamodio eamodio self-assigned this Dec 22, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 22, 2020
@eamodio
Copy link
Member

eamodio commented Dec 22, 2020

@tgreen7 Unfortunately there isn't a way to turn this off currently, but I will add a setting.

Although, the terminal links shouldn't break any existing behavior -- could you provide more details on how it is breaking your workflow?

@tgreen7
Copy link
Author

tgreen7 commented Dec 22, 2020

@eamodio It just blocks the double click selection. When you double click the mouse on text it will select the whole word. But the tooltip blocks the click.

@eamodio
Copy link
Member

eamodio commented Dec 22, 2020

@tgreen7 Hrm, I can't reproduce that, might be OS specific? But even if I could repo, this would be a bug in VS Code itself as the VS Code terminal links API shouldn't cause the impact you are experiencing. Can you open an issue on the VS Code repo so it can get fixed there?

@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Dec 23, 2020
@eamodio
Copy link
Member

eamodio commented Dec 23, 2020

There is now a new gitlens.terminalLinks.enabled setting to control whether terminal links are enabled.

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@tgreen7
Copy link
Author

tgreen7 commented Dec 25, 2020

Perfect. Looks good!

Thanks!

@eamodio eamodio added verified Verified and removed needs-verification Request for community verification labels Dec 25, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request verified Verified
Projects
None yet
Development

No branches or pull requests

2 participants