Skip to content

[contributing] "pushd: not found" with npm install #392

@cmalard

Description

@cmalard
  • GitLens Version: 8.3.3
  • VSCode Version: /
  • OS Version: Ubuntu 16.04

Steps to Reproduce:

  1. clone the repo
  2. npm i
> gitlens@8.3.3 postinstall /home/cedric/Projects/vscode-gitlens
> node ./node_modules/vscode/bin/install && pushd "./src/ui" && npm install --no-save && popd

Detected VS Code engine version: ^1.23.0
Found minimal version that qualifies engine range: 1.23.0
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45/src/vs/vscode.d.ts
vscode.d.ts successfully installed!

sh: 1: pushd: not found

Looks like it has something to do with this : https://stackoverflow.com/questions/45630223/how-to-change-shell-of-npm-install
But I don't really see the point of doing this.

Would it be ok to replace pushd / popd by cd / cd - ? It should have the same behavior and increase the compatibility with more systems.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions