Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1357 Corrects the compare functions #1358

merged 1 commit into from Feb 3, 2021


Copy link

@sueka sueka commented Feb 2, 2021


Corrects the compare functions that use String#localeCompare. Fixes #1357


  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio merged commit fc9757e into gitkraken:main Feb 3, 2021
@eamodio eamodio added this to the Soon™ milestone Feb 3, 2021
@eamodio eamodio self-assigned this Feb 3, 2021
Copy link

eamodio commented Feb 3, 2021

Thank you so much for your contribution!

Thank you!

@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Branch sorting may be reversed
2 participants