Move from Gitlens to the library the columns settings button #2807
Conversation
ericf-axosoft
force-pushed
the
feature/GK-3665_Implement-the-columns-settings-button-directly-in-the-Graph-component
branch
3 times, most recently
from
758fc0d to
1177805
Compare
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
Looks good to me, but since we are releasing GitLens tomorrow, let's hold off on merging this in. Since this proves it can work with the settings button in the graph component, I think you can merge the component-side PR and update the library version so you can use it in GKC @ericf-axosoft
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
Include dependency bump before merge.
ericf-axosoft
force-pushed
the
feature/GK-3665_Implement-the-columns-settings-button-directly-in-the-Graph-component
branch
from
1177805 to
37dcaa9
Compare
ericf-axosoft
deleted the
feature/GK-3665_Implement-the-columns-settings-button-directly-in-the-Graph-component
branch
| <button | ||
| className="column-button" | ||
| type="button" | ||
| role="button" | ||
| data-vscode-context={context?.settings || JSON.stringify({ webviewItem: 'gitlens:graph:settings' })} | ||
| onClick={handleToggleColumnSettings} | ||
| > | ||
| <span className="codicon codicon-settings-gear" aria-label="Column Settings"></span> | ||
| </button> |
There was a problem hiding this comment.
This was removed, but how can GitLens provide the data-vscode-context now? @ericf-axosoft @axosoft-ramint
There was a problem hiding this comment.
The graph sets the data-vscode-context for the button by using the actual contexts.settings input property provided by Gitlens.
There was a problem hiding this comment.
Yep, we pass context to the graph as a prop contexts and context.settings makes it to the button via the prop as contexts.settings
Summary of changes:
Notes
Tasks
230
Internal task:
GK.3665