Skip to content

Conversation

@nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Jul 4, 2024

Description

Use remote.provider.owner as repoOwnerDomain

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev changed the title use remote.provider.owner as repoOwnerDomain GLVSC-570 Fixes error when creating cloud patches for Azure repos Jul 4, 2024
@nzaytsev nzaytsev marked this pull request as ready for review July 18, 2024 08:39
@nzaytsev nzaytsev requested review from d13 and eamodio July 18, 2024 08:39
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the merge commit and use rebase instead

@d13
Copy link
Member

d13 commented Jul 19, 2024

Hey @nzaytsev, while reviewing your PR, I'd suggest the following code changes:

👉 Azure DevOps: need to use project for remote provider

This is a rough hack of trying to get project into repoDomain. For Azure DevOps remotes, we need set the repoDomain property to the project name when creating the remote provider data for a draft. This ensures the correct project is associated with the remote.

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@nzaytsev nzaytsev force-pushed the GLVSC-570-fix-graph-service-error branch 2 times, most recently from 08e41ff to a3f6119 Compare July 22, 2024 08:30
@nzaytsev nzaytsev requested a review from d13 July 22, 2024 08:33
@nzaytsev nzaytsev force-pushed the GLVSC-570-fix-graph-service-error branch 2 times, most recently from c8a463b to 6bc7960 Compare July 22, 2024 08:50
@d13
Copy link
Member

d13 commented Jul 22, 2024

Hey @nzaytsev, while reviewing your PR, I'd suggest the following code changes:

👉 Refactored idea of project for remote provider

This version of my code suggestion moves the decision process out of the draft service and back into the remote provider.

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@nzaytsev nzaytsev force-pushed the GLVSC-570-fix-graph-service-error branch from 6bc7960 to 76a7fdf Compare July 23, 2024 05:01
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this to main after the 15.2.1 patch release goes out.

- Uses remote.provider.owner as repoOwnerDomain
- Passes project as remote provider to azure repos
@nzaytsev nzaytsev force-pushed the GLVSC-570-fix-graph-service-error branch from 366f2d1 to 87232bc Compare July 25, 2024 02:57
@nzaytsev nzaytsev merged commit b4f355b into main Jul 25, 2024
@nzaytsev nzaytsev deleted the GLVSC-570-fix-graph-service-error branch July 25, 2024 03:00
eamodio pushed a commit that referenced this pull request Jul 26, 2024
- Uses remote.provider.owner as repoOwnerDomain
- Passes project as remote provider to azure repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants