Avoids extra repo creation during discovery #3663
Conversation
|
Can I get some context into this one? What problem is it solving, how do I reproduce the issue and verify that it fixes it, etc. At minimum, a reference to an issue would be nice. |
|
Sorry, there isn't any issue. This is just an avoidance of unnecessary work when we are discovering repositories. Stops creating extra repo objects that will ultimately just get discarded later in the flow. Just wanted another pair of eyes on it to see if there was anything glaring. The part I'm worried about the most is the behavior if a "closed" repo exists but we are discovering it and it should be opened. We are triggering an event during discovery which should be fine but timing could be odd |
|
Gotcha, thanks! |
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
Looks good on a quick scan/pass. It's a bit weird that we're doing the logging in isUntrackedRepo but I can see why we wanted to put it there to consolidate the calls.
eamodio
force-pushed
the
debt/avoid-extra-discovery-work
branch
from
43f71eb to
aff55ee
Compare
|
@axosoft-ramint I updated it to change the function to be a |
No description provided.