Better support for DiffNote type (line_range in Position, suggestions, ...) #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimsucks
force-pushed
the
feature/line-range
branch
from
caf105a to
d60d8df
Compare
jmini
reviewed
Sep 23, 2025
Comment on lines
1
to
6
| /* | ||
| * LineRange.java | ||
| * Copyright 2025 Qunhe Tech, all rights reserved. | ||
| * Qunhe PROPRIETARY/CONFIDENTIAL, any form of usage is subject to approval. | ||
| */ | ||
|
|
jmini
reviewed
Sep 23, 2025
There was a problem hiding this comment.
There is probably a test case in TestGitLabApiBeans testing that the java class Position can be serialized and serialized.
It would be good to extend this test (probably extend the JSON used by the test, to reflect this change)
jmini
requested changes
Sep 23, 2025
jmini
approved these changes
Sep 27, 2025
jmini
changed the title
line_range to Position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gitlab.com/api/discussions/#list-project-merge-request-discussion-items
Diff comments also contain position:
[ { "id": "87805b7c09016a7058e91bdbe7b29d1f284a39e6", "individual_note": false, "notes": [ { "id": 1128, "type": "DiffNote", "body": "diff comment", "attachment": null, "author": { "id": 1, "name": "root", "username": "root", "state": "active", "avatar_url": "https://www.gravatar.com/avatar/00afb8fb6ab07c3ee3e9c1f38777e2f4?s=80&d=identicon", "web_url": "http://localhost:3000/root" }, "created_at": "2018-03-04T09:17:22.520Z", "updated_at": "2018-03-04T09:17:22.520Z", "system": false, "noteable_id": 3, "noteable_type": "MergeRequest", "project_id": 5, "noteable_iid": null, "commit_id": "4803c71e6b1833ca72b8b26ef2ecd5adc8a38031", "position": { "base_sha": "b5d6e7b1613fca24d250fa8e5bc7bcc3dd6002ef", "start_sha": "7c9c2ead8a320fb7ba0b4e234bd9529a2614e306", "head_sha": "4803c71e6b1833ca72b8b26ef2ecd5adc8a38031", "old_path": "package.json", "new_path": "package.json", "position_type": "text", "old_line": 27, "new_line": 27, "line_range": { "start": { "line_code": "588440f66559714280628a4f9799f0c4eb880a4a_10_10", "type": "new", "old_line": null, "new_line": 10 }, "end": { "line_code": "588440f66559714280628a4f9799f0c4eb880a4a_11_11", "type": "old", "old_line": 11, "new_line": 11 } } }, "resolved": false, "resolvable": true, "resolved_by": null, "suggestions": [ { "id": 1, "from_line": 27, "to_line": 27, "appliable": true, "applied": false, "from_content": "x", "to_content": "b" } ] } ] } ]