-
Notifications
You must be signed in to change notification settings - Fork 113
feat: add support for configuring push/remote mirrors #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
===========================================
+ Coverage 61.55% 88.54% +26.98%
===========================================
Files 73 74 +1
Lines 3470 3605 +135
===========================================
+ Hits 2136 3192 +1056
+ Misses 1334 413 -921
🚀 New features to boost your workflow:
|
Adjusted processor logic to ensure create mirror is working including sync validation.
Previously a single test tried to validate creating multiple mirrors as well as validating sync function for one of them. To simplify the test logic, they have been separated into different tests. Moving the logic for validating sync function also caught bug in mirror update logic. That has been addressed as well.
Include relevant acceptance test.
8ab3864 to
602229e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for managing/configuring push mirrors in GitLab. The change includes necessary acceptance tests and documentation.
Note: GitLab currently has a limitation in their API for configuring SSH based mirrors. For this type of mirror, GitLab needs to know the "host key" of the target system. This option can only be configured when setting up the mirror manually using the UI. Due to lack of API options in GitLab side, SSH based mirror setup will not be functional.
resolves #873