fix: hooks processor should error gracefully against CE by TimKnight01 · Pull Request #1213 · gitlabform/gitlabform

TimKnight01 · 2026-03-26T10:53:16Z

community edition does not support webhooks
we should error gracefully and allow GitLabForm to continue running even if webhooks are defined
resolves Group Hooks processor tests failing in GitLab CE #1206

codecov · 2026-03-26T10:55:36Z

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.71%. Comparing base (0b70ef1) to head (e99b051).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tlabform/processors/group/group_hooks_processor.py	22.22%	7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0b70ef1) and HEAD (e99b051). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (0b70ef1) HEAD (e99b051)

integration 3 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1213       +/-   ##
===========================================
- Coverage   87.13%   37.71%   -49.43%     
===========================================
  Files          72       72               
  Lines        3779     3786        +7     
===========================================
- Hits         3293     1428     -1865     
- Misses        486     2358     +1872

Flag	Coverage Δ
integration	`26.33% <22.22%> (-58.80%)`	⬇️
unittests	`37.71% <22.22%> (-0.05%)`	⬇️

Files with missing lines	Coverage Δ
...tlabform/processors/group/group_hooks_processor.py	`21.56% <22.22%> (-78.44%)`	⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amimas

Thanks for picking this up @TimKnight01 . Left some comments for us to discuss.

One item I'm wondering is the log message level for CE edition. Should it be an error or a warning instead?

docs/reference/webhooks.md

gitlabform/processors/group/group_hooks_processor.py

tests/acceptance/standard/test_group_hooks.py

TimKnight01 · 2026-03-26T14:11:03Z

@amimas comments applied

tests/acceptance/standard/test_group_hooks.py

amimas

Looks good, but have another question based on discussion on another thread. Hopefully we get this merged soon.

gitlabform/processors/group/group_hooks_processor.py

TimKnight01 · 2026-03-31T08:58:30Z

@amimas - all applied, would be good to get this in, then get all the acceptance tests running against CE prior to making a change to the logging

- community edition does not support webhooks - we should error gracefully and allow GitLabForm to continue running even if webhooks are defined - resolves gitlabform#1206 Signed-off-by: Tim Knight <timknight01@gmail.com>

Signed-off-by: Tim Knight <timknight01@gmail.com>

amimas

Looks good. Thanks again for working through this item.

TimKnight01 requested review from amimas and gdubicki as code owners March 26, 2026 10:53

TimKnight01 had a problem deploying to Integrate Pull Request March 26, 2026 10:53 — with GitHub Actions Error

TimKnight01 had a problem deploying to Integrate Pull Request March 26, 2026 10:58 — with GitHub Actions Error

TimKnight01 temporarily deployed to Integrate Pull Request March 26, 2026 10:58 — with GitHub Actions Inactive

amimas requested changes Mar 26, 2026

View reviewed changes

TimKnight01 force-pushed the i-1205 branch from 8e1348e to 969d80f Compare March 26, 2026 14:10

TimKnight01 had a problem deploying to Integrate Pull Request March 26, 2026 14:10 — with GitHub Actions Error

TimKnight01 temporarily deployed to Integrate Pull Request March 26, 2026 14:11 — with GitHub Actions Inactive

amimas reviewed Mar 26, 2026

View reviewed changes

tests/acceptance/standard/test_group_hooks.py Outdated Show resolved Hide resolved

TimKnight01 temporarily deployed to Integrate Pull Request March 27, 2026 09:06 — with GitHub Actions Inactive

TimKnight01 had a problem deploying to Integrate Pull Request March 30, 2026 08:45 — with GitHub Actions Error

amimas reviewed Mar 30, 2026

View reviewed changes

gitlabform/processors/group/group_hooks_processor.py Outdated Show resolved Hide resolved

TimKnight01 temporarily deployed to Integrate Pull Request March 31, 2026 08:52 — with GitHub Actions Inactive

TimKnight01 had a problem deploying to Integrate Pull Request March 31, 2026 14:17 — with GitHub Actions Error

TimKnight01 added 3 commits March 31, 2026 15:20

fix: hooks processor should error gracefully against CE

34aa48c

- community edition does not support webhooks - we should error gracefully and allow GitLabForm to continue running even if webhooks are defined - resolves gitlabform#1206 Signed-off-by: Tim Knight <timknight01@gmail.com>

chore: improved logging

8627b4d

Signed-off-by: Tim Knight <timknight01@gmail.com>

tests: mark tests as ce

3a10eb1

Signed-off-by: Tim Knight <timknight01@gmail.com>

TimKnight01 added 6 commits March 31, 2026 15:20

chore: apply review comments

1e2d59c

Signed-off-by: Tim Knight <timknight01@gmail.com>

test: skipping tests

ece1c55

Signed-off-by: Tim Knight <timknight01@gmail.com>

fix: logging and tests

07c4498

Signed-off-by: Tim Knight <timknight01@gmail.com>

chore: fix EE test and revert logging changes

3797403

Signed-off-by: Tim Knight <timknight01@gmail.com>

test: fix ee

bfbf8a1

Signed-off-by: Tim Knight <timknight01@gmail.com>

test: fix ee

e99b051

Signed-off-by: Tim Knight <timknight01@gmail.com>

TimKnight01 force-pushed the i-1205 branch from 2cc63ac to e99b051 Compare March 31, 2026 14:21

amimas approved these changes Mar 31, 2026

View reviewed changes

amimas enabled auto-merge (squash) March 31, 2026 14:23

TimKnight01 temporarily deployed to Integrate Pull Request March 31, 2026 14:23 — with GitHub Actions Inactive

amimas merged commit a7cd848 into gitlabform:main Mar 31, 2026
20 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hooks processor should error gracefully against CE#1213

fix: hooks processor should error gracefully against CE#1213
amimas merged 9 commits intogitlabform:mainfrom
TimKnight01:i-1205

TimKnight01 commented Mar 26, 2026

Uh oh!

codecov bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

amimas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimKnight01 commented Mar 26, 2026

Uh oh!

Uh oh!

amimas left a comment

Uh oh!

Uh oh!

TimKnight01 commented Mar 31, 2026

Uh oh!

amimas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

TimKnight01 commented Mar 26, 2026

Uh oh!

codecov bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

amimas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimKnight01 commented Mar 26, 2026

Uh oh!

Uh oh!

amimas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TimKnight01 commented Mar 31, 2026

Uh oh!

amimas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 26, 2026 •

edited

Loading