This repository was archived by the owner on May 12, 2018. It is now read-only.
Default file for gitlab-ci-runner #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 30, 2013 12:35
… Dont start new build unless prev is submited
Init.d Script to Spawn Runner(s) at bootime
…up.out file being placed in the project root
Add extra step: SSH into GitLab to add host ID to known_hosts
Fix init.d script. Missing colon cause error during service registration
added 14 commits
April 24, 2014 23:11
Make sure we submit completed build to coordinator.
Fix typos in Dockerfile
Tempfile permissions
Runner use http to clone repo from source so its no need in ssh key for it Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Drop ssh keygen
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Contributor
Author
|
@jvanbaarsen Could you take a look? |
|
@randx Looks good |
|
Any idea when this could get released? I run gitlab ci runner in an environment where I can't use /home, so a default config file for init.d would be very helpful to have. P.S. Wachiwi, lines 17 and 23 in the default example are the same; don't think they're meant to be. |
Contributor
Author
|
@robodude666 thanks for mentioning. Fixed now |
|
Must have overlooked those lines @robodude666 Thanks :) |
Contributor
Author
|
@jvanbaarsen Could you look at it again? Adapted the variable names inside the init.d script to common style by google |
What did I change: * Added default file for init script to allow configuration for the runner * Updated install area inside ReadMe.md * Adapted the indention of the switch-case to match the rest of the script **EDIT:** * Fixed description of line 17 * Edited init.d-script variables to lowercase variables to match default file
Contributor
Author
|
Fucked up author information -.- |
|
Based on the style guide you linked, constants should be all upper case. |
Contributor
Author
|
yep you're right :D need to change it back ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did I change:
runner
script
EDIT: