Improve event note display in dashboard and project activity views #8020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes on the dashboard views are truncated to 150 characters; this change ensures that when a link's text is truncated it still points to the correct URL.
|
I've prepared a stage. Click to open. |
spec/helpers/events_helper_spec.rb
Outdated
There was a problem hiding this comment.
Do not use %Q unless interpolation is needed. Use %q.
Update the `#first_line_in_markdown` method so that the first line of
parsed text is displayed more reliably, and the continuation indicators
("...") are displayed in all cases where the note is truncated.
Also add Rspec tests for `EventsHelper#event_note`.
mr-vinn
force-pushed
the
note-trunc-link
branch
from
228f152 to
b3c70d0
Compare
mr-vinn
changed the title
|
@mr-vinn looks good! |
dzaporozhets
added a commit
that referenced
this pull request
Oct 13, 2014
Improve event note display in dashboard and project activity views
bbodenmiller
added a commit
to bbodenmiller/gitlabhq
that referenced
this pull request
Oct 13, 2014
Change log entry for gitlabhq#8020
Merged
dzaporozhets
added a commit
that referenced
this pull request
Oct 14, 2014
Improve event note display in dashboard and project activity views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3910
This change improves the event note display in dashboard and project activity views:
<pre/>element.Examples
Old
New