Show total repository size of group and user #9645
Conversation
We didn't specify that the db user needs the right to create temporary tables before. That's why the migration will fail on most installations. This commits removes the "TEMPORARY" from the migration and changes the documentation to include the necessary rights for the future.
Fix failing migration on mysql
We didn't specify that the db user needs the right to create temporary
tables before. That's why the migration will fail on most installations
that installed gitlab according to our documentation. This MR removes
the "TEMPORARY" from the migration and changes the documentation to
include the necessary rights for the future.
Fixes #2590
See merge request !1351
There was a problem hiding this comment.
You can't modify an existing migration I think.
There was a problem hiding this comment.
This looks like a merge from a22b6c5. @KelvinMutuma, can you rebase from master again?
There was a problem hiding this comment.
@stanhu I have since made a rebased merge request on gitlab.
However I am getting strange build errors:
Progress: |WARNING: This version of Gitlab depends on gitlab-shell 2.6.5, but you are running on Unknown. Please update gitlab-shell. -> That's seems a problem of a outdated gitlab-shell on the build machine.
On the gitlab merge request I also refactored the code to take note of @dosire's scalability concern and uploaded screenshots of the changes as stated on the contribution guidelines.
I have restarted the builds to see if they will pass.
PS: I felt that gitlab would be a better place to push a merge request but I should have been prudent enough to cancel this pull request since.
|
Can you post screenshots of this change? I'm not sure if the total repository size needs to be shown in the dashboard page, where commonly-used data is presented. Maybe it's sufficient to show it only in the groups view page. |
|
Closing this in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1366/. |
4 participants
Show total repository size of a user and a group