Fix created_at_height retrieval using git rev-list#35
Merged
volta2030 merged 1 commit intogitledger:mainfrom May 5, 2026
Merged
Fix created_at_height retrieval using git rev-list#35volta2030 merged 1 commit intogitledger:mainfrom
volta2030 merged 1 commit intogitledger:mainfrom
Conversation
Code Review RequiredThis PR contains non-transaction changes and requires validator approval before merging. To approve, post: Required: 1 of 2 validators must approve. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitCoin transaction builder script to populate created_at_height dynamically from the repository’s Git history, improving the accuracy of UTXO metadata generated for transaction PRs.
Changes:
- Computes a
current_heightvalue viagit rev-list --count HEAD. - Sets
created_at_heighton both the recipient UTXO and optional change UTXO to that computed height.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the transaction creation script to set the
created_at_heightfield dynamically based on the current Git commit count, instead of using a hardcoded value. This ensures that the output UTXO JSON files more accurately reflect the current repository state.Transaction metadata improvements:
.github/scripts/create_transaction.py: Replaces the hardcodedcreated_at_heightvalue with the current Git commit count for both the main output UTXO and the change UTXO, making the transaction metadata more representative of the repository's state at creation time. [1] [2]