Remove warning, "No dst branch specified, using upstream branch..." #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I agree, thank you. I've changed the license to MIT since you've opened the PR, are you ok with contributing your change under the new license? |
Contributor
Author
|
Sure, no problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #164 by removing the message altogether.
Rationale: This warning is given when a user follows the "happy path"; they've set up an upstream remote, and are using the basic invocation of
publish:$ gl publish ! No dst branch specified, using upstream branch XXX/YYYAs a general rule, we shouldn't warn the user that we're doing as they've instructed. And in this case, informational messages follow, so we don't need to do that here either. The right choice is to remove this message altogether.