fix fuse mount#2069
Conversation
Signed-off-by: jackie <jackieismpc@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca3bb7ca3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 360d15088b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !best_effort_detach_mountpoint(mountpoint, false).await | ||
| && !best_effort_detach_mountpoint(mountpoint, true).await | ||
| { |
There was a problem hiding this comment.
prepare_mountpoint_for_retry now hard-fails if both best_effort_detach_mountpoint calls return false, but best_effort_detach_mountpoint returns false whenever fusermount cannot be executed (e.g., hosts that only have fusermount3 or no helper installed). In that environment, any leftover mountpoint directory for the same job id causes remount to fail before remove_mountpoint_path runs, even if unmount_job already detached the mount. This turns a best-effort cleanup path into a hard availability regression for retry/remount flows.
Useful? React with 👍 / 👎.
2 participants
old fuse mount clean